[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] sstate: Consider .lock suffix for when loading sstate file from mirror
From:       "Richard Purdie" <richard.purdie () linuxfoundation ! org>
Date:       2021-10-31 23:11:03
Message-ID: 660173710f5a6356f152a2965134bbf0680c9927.camel () linuxfoundation ! org
[Download RAW message or body]

On Sun, 2021-10-31 at 21:08 +0100, Manuel Leonhardt wrote:
> When using an sstate mirror over HTTP/S, a lockfile is created during
> download. Previously, this resulted in an OSError (ENAMETOOLONG) in the
> bb.utils.lockfile function because the lockfile has the filename of the
> sstate file plus ".lock". Since this case is also not handled properly
> in bb.utils.lockfile, this caused populate tasks to hang indefinitely.
> 
> Also, previously when generating a shorter filename, the reserved
> characters for .siginfo and now .lock were not considered. This is now
> fixed by using limit instead of 254, which is the maximum length.
> 
> Signed-off-by: Manuel Leonhardt <mleonhardt@arri.de>
> ---
>  meta/classes/sstate.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I think it may be better to fix the lock function not to use large filenames?
The worst case is two locks overlap with the truncated names but that isn't a
bad fallback situation...

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#157693): https://lists.openembedded.org/g/openembedded-core/message/157693
Mute This Topic: https://lists.openembedded.org/mt/86725115/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]