[prev in list] [next in list] [prev in thread] [next in thread]
List: openembedded-core
Subject: Re: [OE-core] [PATCH] strace_5.13 -> strace 5.14
From: "Khem Raj" <raj.khem () gmail ! com>
Date: 2021-09-30 15:23:17
Message-ID: CAMKF1souJT2zctaCY5dubAuQT+zJtYkX0Kfsm3D_O251DnabYA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Sep 29, 2021 at 11:46 PM Alexandre Belloni <
alexandre.belloni@bootlin.com> wrote:
> Hello,
>
> On 29/09/2021 13:57:10-0700, Khem Raj wrote:
> > From: Persian Prince <persianpros@yahoo.com>
> >
> > Strace 5.13 won't compile with 5.14 headers:
> >
> > | ../../strace-5.13/src/fs_x_ioctl.c: In function 'fs_x_ioctl':
> > | ../../strace-5.13/src/fs_x_ioctl.c:64:14: error: invalid application
> of 'sizeof' to incomplete type 'struct fsxattr'
> > | 64 | case FS_IOC_FSGETXATTR:
> > | | ^~~~~~~~~~~~~~~~~
> > | ../../strace-5.13/src/fs_x_ioctl.c:71:14: error: invalid application
> of 'sizeof' to incomplete type 'struct fsxattr'
> > | 71 | case FS_IOC_FSSETXATTR:
> > | | ^~~~~~~~~~~~~~~~~
> > | make[3]: *** [Makefile:5011: libstrace_a-fs_x_ioctl.o] Error 1
> > | make[3]: *** Waiting for unfinished jobs....
> >
> > According to https://strace.io/files/5.14/:
> >
> > * Improvements
> > * Implemented decoding of memfd_secret and quotactl_fd syscalls,
> > introduced in Linux 5.14.
> > * Enhanced prctl syscall decoding.
> > * Enhanced decoding of IFLA_* netlink attributes.
> > * Enhanced decoding of MDBA_ROUTER_PATTR_* mdb router port netlink
> attributes.
> > * Updated lists of BPF_*, IORING_*, MADV_*, MOUNT_ATTR_*, SCTP_*,
> > and UFFD_* constants.
> > * Updated lists of ioctl commands from Linux 5.14.
> >
> > Persian Prince <persianpros@yahoo.com>
>
> I guess this should have been an SoB.
>
> However, this is not applicable as we already carry a similar patch in
> kirkstone-next.
If you do that's fine see if commit msg makes sense and perhaps transplant
that part to what you are staging
>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb} | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > rename meta/recipes-devtools/strace/{strace_5.13.bb => strace_5.14.bb}
> (96%)
> >
> > diff --git a/meta/recipes-devtools/strace/strace_5.13.bb
> b/meta/recipes-devtools/strace/strace_5.14.bb
> > similarity index 96%
> > rename from meta/recipes-devtools/strace/strace_5.13.bb
> > rename to meta/recipes-devtools/strace/strace_5.14.bb
> > index 7d93f2da98..02a4843edf 100644
> > --- a/meta/recipes-devtools/strace/strace_5.13.bb
> > +++ b/meta/recipes-devtools/strace/strace_5.14.bb
> > @@ -15,7 +15,7 @@ SRC_URI = "
> https://strace.io/files/${PV}/strace-${PV}.tar.xz \
> > file://uintptr_t.patch \
> > file://0001-strace-fix-reproducibilty-issues.patch \
> > "
> > -SRC_URI[sha256sum] =
> "5acc34888b9d510ad6ac915d4a8df08f51cf1ae920ea24649f6a4bb984d0b656"
> > +SRC_URI[sha256sum] =
> "901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"
> >
> > inherit autotools ptest
> >
> > --
> > 2.33.0
> >
>
> >
> >
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
[Attachment #5 (text/html)]
<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Wed, Sep 29, 2021 at 11:46 PM Alexandre Belloni <<a \
href="mailto:alexandre.belloni@bootlin.com">alexandre.belloni@bootlin.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br> <br>
On 29/09/2021 13:57:10-0700, Khem Raj wrote:<br>
> From: Persian Prince <<a href="mailto:persianpros@yahoo.com" \
target="_blank">persianpros@yahoo.com</a>><br> > <br>
> Strace 5.13 won't compile with 5.14 headers:<br>
> <br>
> | ../../strace-5.13/src/fs_x_ioctl.c: In function 'fs_x_ioctl':<br>
> | ../../strace-5.13/src/fs_x_ioctl.c:64:14: error: invalid application of \
'sizeof' to incomplete type 'struct fsxattr'<br> > | 64 | \
case FS_IOC_FSGETXATTR:<br> > | | \
^~~~~~~~~~~~~~~~~<br> > | ../../strace-5.13/src/fs_x_ioctl.c:71:14: error: invalid \
application of 'sizeof' to incomplete type 'struct fsxattr'<br> > \
| 71 | case FS_IOC_FSSETXATTR:<br> > | | \
^~~~~~~~~~~~~~~~~<br> > | make[3]: *** [Makefile:5011: libstrace_a-fs_x_ioctl.o] \
Error 1<br> > | make[3]: *** Waiting for unfinished jobs....<br>
> <br>
> According to <a href="https://strace.io/files/5.14/" rel="noreferrer" \
target="_blank">https://strace.io/files/5.14/</a>:<br> > <br>
> * Improvements<br>
> * Implemented decoding of memfd_secret and quotactl_fd syscalls,<br>
> introduced in Linux 5.14.<br>
> * Enhanced prctl syscall decoding.<br>
> * Enhanced decoding of IFLA_* netlink attributes.<br>
> * Enhanced decoding of MDBA_ROUTER_PATTR_* mdb router port netlink \
attributes.<br> > * Updated lists of BPF_*, IORING_*, MADV_*, MOUNT_ATTR_*, \
SCTP_*,<br> > and UFFD_* constants.<br>
> * Updated lists of ioctl commands from Linux 5.14.<br>
> <br>
> Persian Prince <<a href="mailto:persianpros@yahoo.com" \
target="_blank">persianpros@yahoo.com</a>><br> <br>
I guess this should have been an SoB.<br>
<br>
However, this is not applicable as we already carry a similar patch in<br>
kirkstone-next.</blockquote><div dir="auto"><br></div><div dir="auto">If you do \
that's fine see if commit msg makes sense and perhaps transplant that part to what \
you are staging </div><div dir="auto"><br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" dir="auto"><br> \
<br> > Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" \
target="_blank">raj.khem@gmail.com</a>><br> > ---<br>
> meta/recipes-devtools/strace/{<a href="http://strace_5.13.bb" rel="noreferrer" \
target="_blank">strace_5.13.bb</a> => <a href="http://strace_5.14.bb" \
rel="noreferrer" target="_blank">strace_5.14.bb</a>} | 2 +-<br> > 1 file \
changed, 1 insertion(+), 1 deletion(-)<br> > rename \
meta/recipes-devtools/strace/{<a href="http://strace_5.13.bb" rel="noreferrer" \
target="_blank">strace_5.13.bb</a> => <a href="http://strace_5.14.bb" \
rel="noreferrer" target="_blank">strace_5.14.bb</a>} (96%)<br> > <br>
> diff --git a/meta/recipes-devtools/strace/<a href="http://strace_5.13.bb" \
rel="noreferrer" target="_blank">strace_5.13.bb</a> b/meta/recipes-devtools/strace/<a \
href="http://strace_5.14.bb" rel="noreferrer" target="_blank">strace_5.14.bb</a><br> \
> similarity index 96%<br> > rename from meta/recipes-devtools/strace/<a \
href="http://strace_5.13.bb" rel="noreferrer" target="_blank">strace_5.13.bb</a><br> \
> rename to meta/recipes-devtools/strace/<a href="http://strace_5.14.bb" \
rel="noreferrer" target="_blank">strace_5.14.bb</a><br> > index \
7d93f2da98..02a4843edf 100644<br> > --- a/meta/recipes-devtools/strace/<a \
href="http://strace_5.13.bb" rel="noreferrer" target="_blank">strace_5.13.bb</a><br> \
> +++ b/meta/recipes-devtools/strace/<a href="http://strace_5.14.bb" \
rel="noreferrer" target="_blank">strace_5.14.bb</a><br> > @@ -15,7 +15,7 @@ \
SRC_URI = "<a href="https://strace.io/files/$%7BPV%7D/strace-$%7BPV%7D.tar.xz" \
rel="noreferrer" target="_blank">https://strace.io/files/${PV}/strace-${PV}.tar.xz</a> \
\<br> > file://uintptr_t.patch \<br>
> file://0001-strace-fix-reproducibilty-issues.patch \<br>
> "<br>
> -SRC_URI[sha256sum] = \
"5acc34888b9d510ad6ac915d4a8df08f51cf1ae920ea24649f6a4bb984d0b656"<br> > \
+SRC_URI[sha256sum] = \
"901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"<br> > \
<br> > inherit autotools ptest<br>
> <br>
> -- <br>
> 2.33.0<br>
> <br>
<br>
> <br>
> <br>
> <br>
<br>
<br>
-- <br>
Alexandre Belloni, co-owner and COO, Bootlin<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer" \
target="_blank">https://bootlin.com</a><br> </blockquote></div></div>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156506): https://lists.openembedded.org/g/openembedded-core/message/156506
Mute This Topic: https://lists.openembedded.org/mt/85959484/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic