[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] kernel: Use unexpanded EXTENDPKGV
From:       "Ross Burton" <ross () burtonini ! com>
Date:       2021-08-31 14:37:20
Message-ID: CAAnfSTs6Wbobis81jti=xRRHDkoajXwUvCNJ8uHGtV9ZscAhtA () mail ! gmail ! com
[Download RAW message or body]

My variation was just:

-    fullver = d.getVar('EXTENDPKGV')
+    fullver = d.getVar('EXTENDPKGV', False)

Either have the same net result I guess.

Ross

On Tue, 31 Aug 2021 at 14:30, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> 
> EXTENDPKGV can contain AUTOINC so use an expanded form in the variables allowing
> for later expansion during packaging to avoid race issues over the variable and
> the build failures that can result.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/classes/kernel.bbclass | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index ab60e060c6e..d13c38fb026 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -92,18 +92,17 @@ python __anonymous () {
> kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
> imagedest = d.getVar('KERNEL_IMAGEDEST')
> 
> -    fullver = d.getVar('EXTENDPKGV')
> for type in types.split():
> if bb.data.inherits_class('nopackages', d):
> continue
> typelower = type.lower()
> d.appendVar('PACKAGES', ' %s-image-%s' % (kname, typelower))
> d.setVar('FILES:' + kname + '-image-' + typelower, '/' + imagedest + '/' + type + \
>                 '-${KERNEL_VERSION_NAME}' + ' /' + imagedest + '/' + type)
> -        d.appendVar('RDEPENDS:%s-image' % kname, ' %s-image-%s (= %s)' % (kname, \
> typelower, fullver)) +        d.appendVar('RDEPENDS:%s-image' % kname, ' \
> %s-image-%s (= ${EXTENDPKGV})' % (kname, typelower)) splitmods = \
> d.getVar("KERNEL_SPLIT_MODULES") if splitmods != '1':
> -            d.appendVar('RDEPENDS:%s-image' % kname, ' %s-modules (= %s)' % \
>                 (kname, fullver))
> -            d.appendVar('RDEPENDS:%s-image-%s' % (kname, typelower), ' \
> %s-modules-${KERNEL_VERSION_PKG_NAME} (= %s)' % (kname, fullver)) +            \
> d.appendVar('RDEPENDS:%s-image' % kname, ' %s-modules (= ${EXTENDPKGV})' % kname) + \
> d.appendVar('RDEPENDS:%s-image-%s' % (kname, typelower), ' \
> %s-modules-${KERNEL_VERSION_PKG_NAME} (= ${EXTENDPKGV})' % kname) \
> d.setVar('PKG:%s-modules' % kname, '%s-modules-${KERNEL_VERSION_PKG_NAME}' % kname) \
> d.appendVar('RPROVIDES:%s-modules' % kname, '%s-modules-${KERNEL_VERSION_PKG_NAME}' \
> % kname) 
> --
> 2.32.0
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155537): https://lists.openembedded.org/g/openembedded-core/message/155537
Mute This Topic: https://lists.openembedded.org/mt/85275780/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]