[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] buildstats.bbclass: collect host data only when do_testimage fails
From:       "Richard Purdie" <richard.purdie () linuxfoundation ! org>
Date:       2021-08-30 20:21:59
Message-ID: 30c543029b88d5e5be590cb37aeef864cdcd404f.camel () linuxfoundation ! org
[Download RAW message or body]

On Fri, 2021-08-27 at 15:32 -0400, Sakib Sajal wrote:
> Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
> ---
>  meta/classes/buildstats.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
> index 0de605200a..874d30b292 100644
> --- a/meta/classes/buildstats.bbclass
> +++ b/meta/classes/buildstats.bbclass
> @@ -250,7 +250,7 @@ python run_buildstats () {
>                      except subprocess.CalledProcessError as err:
>                          bb.warn("Failed to get rootfs size: %s" % err.output.decode('utf-8'))
>  
> -    elif isinstance(e, bb.build.TaskFailed):
> +    elif isinstance(e, bb.build.TaskFailed) and e.task == "do_testimage":
>          # Can have a failure before TaskStarted so need to mkdir here too
>          bb.utils.mkdirhier(taskdir)
>          write_task_data("failed", os.path.join(taskdir, e.task), e, d)

Doesn't this remove all failure handling rather than just host data? That
probably isn't what we want and isn't what the commit message says.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155506): https://lists.openembedded.org/g/openembedded-core/message/155506
Mute This Topic: https://lists.openembedded.org/mt/85194366/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]