From openembedded-core Wed Apr 28 05:05:46 2021 From: "Khem Raj" Date: Wed, 28 Apr 2021 05:05:46 +0000 To: openembedded-core Subject: [OE-core] [PATCH] busybox: Enable long options for enabled applets Message-Id: <20210428050546.1708751-1-raj.khem () gmail ! com> X-MARC-Message: https://marc.info/?l=openembedded-core&m=161958634826609 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--yVJ6AN5cTJdwuROLkgZE" --yVJ6AN5cTJdwuROLkgZE Content-Transfer-Encoding: 8bit certain applets are enabled but the long options are not enabled for them, it results in subtle failures in ptests where its expecting these options e.g. gzip --best is commonly used in many package tests e.g. root@qemux86-64:/usr/lib# grep -r "\-\-best" * acl/ptest/Makefile:GZIP_ENV = --best attr/ptest/Makefile:GZIP_ENV = --best coreutils/ptest/Makefile:GZIP_ENV = --best ethtool/ptest/Makefile:GZIP_ENV = --best libxml2/ptest/Makefile:GZIP_ENV = --best lttng-tools/ptest/Makefile:GZIP_ENV = --best opkg/ptest/Makefile:GZIP_ENV = --best perl/ptest/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm: COMPRESS ('gzip --best') python3.9/test/test_gzip.py: for compress_level in ('--fast', '--best'): ... this ensures that these options are enabled by default, which makes them more compatible than now with coreutils provided utilities busybox size grows by 4K which perhaps is acceptable --rwxr-xr-x root root 817704 ./bin/busybox.nosuid +-rwxr-xr-x root root 821800 ./bin/busybox.nosuid This makes autopoint-3/gettext pass Signed-off-by: Khem Raj --- meta/recipes-core/busybox/busybox/getopts.cfg | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meta/recipes-core/busybox/busybox/getopts.cfg b/meta/recipes-core/busybox/busybox/getopts.cfg index 8db0a4a8f2..aeb5ac691f 100644 --- a/meta/recipes-core/busybox/busybox/getopts.cfg +++ b/meta/recipes-core/busybox/busybox/getopts.cfg @@ -1,3 +1,10 @@ CONFIG_GETOPT=y CONFIG_LONG_OPTS=y CONFIG_FEATURE_GETOPT_LONG=y +CONFIG_FEATURE_GZIP_LONG_OPTIONS=y +CONFIG_FEATURE_TAR_LONG_OPTIONS=y +CONFIG_FEATURE_CHOWN_LONG_OPTIONS=y +CONFIG_FEATURE_CP_LONG_OPTIONS=y +CONFIG_FEATURE_INSTALL_LONG_OPTIONS=y +CONFIG_FEATURE_DIFF_LONG_OPTIONS=y +CONFIG_FEATURE_SETCONSOLE_LONG_OPTIONS=y -- 2.31.1 --yVJ6AN5cTJdwuROLkgZE Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Links: You receive all messages sent to this group. View/Reply Online (#151051): https://lists.openembedded.org/g/openembedded= -core/message/151051 Mute This Topic: https://lists.openembedded.org/mt/82422704/4454766 Group Owner: openembedded-core+owner@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ope= nembedded-core@marc.info] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --yVJ6AN5cTJdwuROLkgZE--