[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 08/24] libdnf: update 0.55.2 -> 0.58.0
From:       "Khem Raj" <raj.khem () gmail ! com>
Date:       2021-02-28 19:30:00
Message-ID: 82beb9df-56ea-3081-b502-4fce8a65f4d4 () gmail ! com
[Download RAW message or body]

On 2/28/21 11:07 AM, Alexander Kanavin wrote:
> On Sun, 28 Feb 2021 at 20:04, Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
> 
> 
>     It seems __WORDISIZE is what is being used here, a portable way would be
> 
>     #include <limits.h>
>     #if (ULONG_MAX == 0xffffffffffffffff)
>     64bit wordlen stuff
>     #else
>     32bit stuff
>     #endif
> 
>     if we still want to keep using internal libc internal define __WORDSIZE
>     then for musl include sys/user.h headers under bits/ dir are usually
>     not
>     portable and not meant for direct includes
> 
>     #include <features.h>
>     #ifdef __GLIBC__
>     #include <bits/wordsize.h>
>     #endif
>     #include <sys/user.h>
> 
> 
> Can you send a patch upstream for this please? I have filed a ticket 
> which you can reference:
> https://github.com/rpm-software-management/libdnf/issues/1146 
> <https://github.com/rpm-software-management/libdnf/issues/1146>

This is a review so please fix it as suggested in OE atleast since you 
will have test setups I do not have rpm/dnf setups

> 
> Alex


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#148775): https://lists.openembedded.org/g/openembedded-core/message/148775
Mute This Topic: https://lists.openembedded.org/mt/80974301/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]