[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH v3] sanity.bbclass: check if PSEUDO_IGNORE_PATHS and paths under pseudo control
From:       "Richard Purdie" <richard.purdie () linuxfoundation ! org>
Date:       2021-01-31 21:50:11
Message-ID: 1559e89a094f9f6eaa3bfa9b01f6126a36e1d0d3.camel () linuxfoundation ! org
[Download RAW message or body]

On Sun, 2021-01-31 at 14:26 -0500, Dorinda wrote:
> 
> +    # Check if PSEUDO_IGNORE_PATHS and and paths under pseudo control overlap
> +    pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
> +    pseudo_control_dir = "${D},${PKGD},${PKGDEST},${IMAGEROOTFS},${SDK_OUTPUT}"
> +    pseudocontroldir = d.getVar('pseudo_control_dir', expand=True).split(",")

I'm not sure that would actually work without a setVar as
pseudo_control_dir isn't a variable.

What you probably want is:

pseudocontroldir = d.expand(pseudo_control_dir, expand=True).split(",")


How did you test this? Did you try setting S = "${WORKDIR}/pack" in a
recipe to ensure it correctly detects the issue?


> +    for i in pseudoignorepaths:
> +        for j in pseudocontroldir:
> +            if i and j:
> +                if j.startswith(i):
> +                    status.addresult("a path included in PSEUDO_IGNORE_PATHS " + \
> str(i) + " and the path " + str(j) + " are overlapping each other, please set this \
> path " + str(j) + " to point to a different directory. \n")

How about improving this to:

'''
A path in PSEUDO_IGNORE_PATHS " + str(i) + " and the path " + str(j) +
" overlap and this will break pseudo permission and ownership tracking.
Please set the path " + str(j) + " to a different directory which does
not overlap with pseudo controlled directories. 
'''

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#147498): https://lists.openembedded.org/g/openembedded-core/message/147498
Mute This Topic: https://lists.openembedded.org/mt/80265296/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]