[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core][PATCH 1/3] pseudo: use PSEUDO_CONSIDER_PATHS for path filetering
From:       "Richard Purdie" <richard.purdie () linuxfoundation ! org>
Date:       2021-01-30 11:13:52
Message-ID: 38ac3474d3115a65dae518b8577a81ae9f872042.camel () linuxfoundation ! org
[Download RAW message or body]

On Fri, 2021-01-29 at 16:33 +0800, Chen Qi wrote:
> Patch pseudo to only take into consideration paths we care about.
> Use PSEUDO_CONSIDER_PATHS to hold the paths. The behavior of this
> var is the opposite of PSEUDO_IGNORE_PATHS.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> ...DO_CONSIDER_PATHS-for-path-filtering.patch | 55 +++++++++++++++++++
> meta/recipes-devtools/pseudo/pseudo_git.bb    |  1 +
> 2 files changed, 56 insertions(+)
> create mode 100644 \
> meta/recipes-devtools/pseudo/files/0001-pseudo-use-PSEUDO_CONSIDER_PATHS-for-path-filtering.patch
> 

This is interesting but these patches would need more work before we
could consider this.

a) It no longer supports PSEUDO_IGNORE_PATHS and we have code widely
using that. We'd probably need to support both options.

b) There are a load of references to PSEUDO_IGNORE_PATHS in OE-Core
which this series doesn't touch in the following files:

meta/lib/oeqa/selftest/cases/runtime_test.py
meta/classes/sanity.bbclass
meta/classes/sanity.bbclass
meta/classes/sanity.bbclass
meta/classes/base.bbclass
meta/classes/image_types_wic.bbclass
meta/classes/populate_sdk_base.bbclass
meta/classes/license.bbclass
scripts/lib/wic/partition.py

We'd need to do something with those. Was wic tested? Were oe-selftests
run?

c) Has the output been compared before and after this change to ensure
permissions/ownership is correctly being handled in all cases?

d) The pseudo authors explicitly asked we implement exclusions, not an
inclusion list like this. I'd want to understand more about why they
made such a strong recommendation. FWIW I'd originally hoped to do
something like this patch but they dissuaded me.

e) The name PSEUDO_CONSIDER_PATHS doesn't sound right to me, if we did
this I'd like to find a better one.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#147475): https://lists.openembedded.org/g/openembedded-core/message/147475
Mute This Topic: https://lists.openembedded.org/mt/80205583/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]