[prev in list] [next in list] [prev in thread] [next in thread]
List: openembedded-core
Subject: Re: [OE-core] [PATCH v2 0/2] meson: fixup nativesdk sysroot
From: "Randy Li" <ayaka () soulik ! info>
Date: 2020-12-31 6:15:54
Message-ID: 5EC7D728-291A-4A57-B6B7-3989DFAE84E6 () soulik ! info
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec 31, 2020, at 12:43 PM, Saini, Naveen Kumar <naveen.kumar.saini@intel.com> \
> wrote:
> This failing in case of non-native sdk too, where PKG_CONFIG_SYSROOT_DIR is also \
> exported. It does not prepend PKG_CONFIG_SYSROOT_DIR path.
> I think it should be fixed manually by prepending sysroot path.
I was having such plan but Gstreamer people said it should be fixed in OE itself
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1253
>
> + pkgconf_sysroot = run_command(python3, '-c', 'import os; \
> print(os.environ.get("PKG_CONFIG_SYSROOT_DIR"))').stdout().strip() mfx_incdir = \
> mfx_dep.get_pkgconfig_variable('includedir') + mfx_incdir = pkgconf_sysroot + \
> mfx_incdir
Sorry, I don't what the non-native sdk means here, since \
get_pkgconfig_variable('includedir') from meson would apply the pkgconfig sysroot \
setting from the meson, it would be fine.
>
> Ref: https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gs \
> treamer/gstreamer1.0-plugins-bad/0004-opencv-resolve-missing-opencv-data-dir-in-yocto-buil.patch#n26
>
>
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Randy Li
> > Sent: Thursday, December 31, 2020 9:46 AM
> > To: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH v2 0/2] meson: fixup nativesdk sysroot
> >
> >
> > > On Dec 30, 2020, at 10:05 PM, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > >
> > > > On Tue, 2020-12-29 at 11:55 +0800, Randy Li wrote:
> > > > I still saw the request for this patch from Gstreamer users
> > > > sometimes. I have verified this version would work fine.
> > > >
> > > > Only the exported SDK would need this patch.
> > >
> > > Thanks for the patches, is there something we should add to the
> > > automated tests (e.g. in meta/lib/oeqa/sdk/cases) to test this?
> > >
> > The original case is that when I was compiling the Gstreamer plugins bad for
> > Intel Media SDK, the include path from the pkg-config would be one without
> > sysroot. Most of packages won't meet such problem, they can just ordinary
> > includedir, which is not from meson but compiler I think, then prepend a
> > package name when its code include thems.
> >
> > I think this case only fix those package using meson and need to get
> > something likes path information from the pkg-config.
> >
> > I have not read the QA part, so I don't know what is necessary for such case.
> > Maybe a check for the environment variables from all those auto build tools ?
> > I need to read and make the right comment as well as I welcome the idea
> > from the others.
> > > Cheers,
> > >
> > > Richard
> > >
> > Sincerely
> > Randy
[Attachment #5 (text/html)]
<html><head><meta http-equiv="content-type" content="text/html; \
charset=utf-8"></head><body dir="auto"><br><div dir="ltr"><br>On Dec 31, 2020, at \
12:43 PM, Saini, Naveen Kumar <<a \
href="mailto:naveen.kumar.saini@intel.com">naveen.kumar.saini@intel.com</a>> \
wrote:<br><br></div><blockquote type="cite"><div dir="ltr"><span>This failing in case \
of non-native sdk too, where PKG_CONFIG_SYSROOT_DIR is also exported. It does not \
prepend PKG_CONFIG_SYSROOT_DIR path. </span><br><span></span><br><span>I think it \
should be fixed manually by prepending sysroot path. </span><br></div></blockquote>I \
was having such plan but Gstreamer people said it should be fixed in OE itself<div><a \
href="https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1253"> \
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1253</a></div><div><br><blockquote \
type="cite"><div dir="ltr"><span></span><br><span>+ pkgconf_sysroot = \
run_command(python3, '-c', 'import os; \
print(os.environ.get("PKG_CONFIG_SYSROOT_DIR"))').stdout().strip()</span><br><span> \
mfx_incdir = \
mfx_dep.get_pkgconfig_variable('includedir')</span><br><span>+ mfx_incdir = \
pkgconf_sysroot + mfx_incdir</span><br><span></span><br></div></blockquote>Sorry, \
I don't what the non-native sdk means here, since g<span style="background-color: \
rgba(255, 255, 255, 0);">et_pkgconfig_variable('includedir') from meson would apply \
the pkgconfig sysroot setting from the meson, it would be fine.</span><blockquote \
type="cite"><div dir="ltr"><span>Ref: <a \
href="https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gst \
reamer/gstreamer1.0-plugins-bad/0004-opencv-resolve-missing-opencv-data-dir-in-yocto-b \
uil.patch#n26">https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multi \
media/gstreamer/gstreamer1.0-plugins-bad/0004-opencv-resolve-missing-opencv-data-dir-i \
n-yocto-buil.patch#n26</a></span><br><span></span><br><span></span><br><blockquote \
type="cite"><span>-----Original Message-----</span><br></blockquote><blockquote \
type="cite"><span>From: <a \
href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.openembedded.org</a> \
<openembedded-</span><br></blockquote><blockquote type="cite"><span><a \
href="mailto:core@lists.openembedded.org">core@lists.openembedded.org</a>> On \
Behalf Of Randy Li</span><br></blockquote><blockquote type="cite"><span>Sent: \
Thursday, December 31, 2020 9:46 AM</span><br></blockquote><blockquote \
type="cite"><span>To: Richard Purdie <<a \
href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>></span><br></blockquote><blockquote \
type="cite"><span>Cc: <a \
href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.openembedded.org</a></span><br></blockquote><blockquote \
type="cite"><span>Subject: Re: [OE-core] [PATCH v2 0/2] meson: fixup nativesdk \
sysroot</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><blockquote \
type="cite"><span>On Dec 30, 2020, at 10:05 PM, Richard \
Purdie</span><br></blockquote></blockquote><blockquote type="cite"><span><<a \
href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>> \
wrote:</span><br></blockquote><blockquote type="cite"><blockquote \
type="cite"><span></span><br></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><blockquote type="cite"><span>On Tue, 2020-12-29 \
at 11:55 +0800, Randy Li \
wrote:</span><br></blockquote></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><blockquote type="cite"><span>I still saw the \
request for this patch from Gstreamer \
users</span><br></blockquote></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><blockquote type="cite"><span>sometimes. I have \
verified this version would work \
fine.</span><br></blockquote></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><blockquote \
type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><blockquote type="cite"><span>Only the exported \
SDK would need this patch.</span><br></blockquote></blockquote></blockquote><blockquote \
type="cite"><blockquote \
type="cite"><span></span><br></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><span>Thanks for the patches, is there something \
we should add to the</span><br></blockquote></blockquote><blockquote \
type="cite"><blockquote type="cite"><span>automated tests (e.g. in \
meta/lib/oeqa/sdk/cases) to test \
this?</span><br></blockquote></blockquote><blockquote type="cite"><blockquote \
type="cite"><span></span><br></blockquote></blockquote><blockquote \
type="cite"><span>The original case is that when I was compiling the Gstreamer \
plugins bad for</span><br></blockquote><blockquote type="cite"><span>Intel Media SDK, \
the include path from the pkg-config would be one \
without</span><br></blockquote><blockquote type="cite"><span>sysroot. Most of \
packages won't meet such problem, they can just \
ordinary</span><br></blockquote><blockquote type="cite"><span>includedir, which is \
not from meson but compiler I think, then prepend \
a</span><br></blockquote><blockquote type="cite"><span>package name when its code \
include thems.</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><span>I think this \
case only fix those package using meson and need to \
get</span><br></blockquote><blockquote type="cite"><span>something likes path \
information from the pkg-config.</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><span>I have not \
read the QA part, so I don't know what is necessary for such \
case.</span><br></blockquote><blockquote type="cite"><span>Maybe a check for the \
environment variables from all those auto build tools \
?</span><br></blockquote><blockquote type="cite"><span>I need to read and make the \
right comment as well as I welcome the idea</span><br></blockquote><blockquote \
type="cite"><span>from the others.</span><br></blockquote><blockquote \
type="cite"><blockquote \
type="cite"><span>Cheers,</span><br></blockquote></blockquote><blockquote \
type="cite"><blockquote \
type="cite"><span></span><br></blockquote></blockquote><blockquote \
type="cite"><blockquote \
type="cite"><span>Richard</span><br></blockquote></blockquote><blockquote \
type="cite"><blockquote \
type="cite"><span></span><br></blockquote></blockquote><blockquote \
type="cite"><span>Sincerely</span><br></blockquote><blockquote \
type="cite"><span>Randy</span><br></blockquote></div></blockquote></div></body></html>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#146321): https://lists.openembedded.org/g/openembedded-core/message/146321
Mute This Topic: https://lists.openembedded.org/mt/79284744/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic