[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] insane: add GitLab /archive/ tests
From:       "Andrey Zhizhikin" <andrey.z () gmail ! com>
Date:       2020-10-31 21:06:27
Message-ID: CAHtQpK5A18nXRZZSAr2YXj2dvE8aztnVDyZxSsLEJBkNTNQy3g () mail ! gmail ! com
[Download RAW message or body]

On Sat, Oct 31, 2020 at 9:56 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
> 
> Has this been tested?
> 
> > > > print(re.search(r"github|gitlab\.com/.+/.+/archive/.+", \
> > > > "github/random/url/will/match"))
> <re.Match object; span=(0, 6), match='github'>

Was actually writing the reply to hold this one off - it gives a lot
of false positives, messed up the 're'... :\

Would come up with V2 for this one, sorry for that...

> 
> Alex
> 
> On Sat, 31 Oct 2020 at 21:47, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
> > 
> > Archives produced by GitLab should be avoided in the same way as those
> > produced by GitHub.
> > 
> > Extend SRC_URI check to include GitLab and inform user that recipe
> > should be converted to use git protocol.
> > 
> > Link: https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg73109.html
> >                 
> > Link: https://lists.openembedded.org/g/openembedded-core/message/144035
> > Cc: Martin Jansa <martin.jansa@gmail.com>
> > Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > ---
> > meta/classes/insane.bbclass | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> > index c6dff9659c..66c34abc95 100644
> > --- a/meta/classes/insane.bbclass
> > +++ b/meta/classes/insane.bbclass
> > @@ -976,8 +976,8 @@ def package_qa_check_src_uri(pn, d, messages):
> > package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d)
> > 
> > for url in d.getVar("SRC_URI").split():
> > -        if re.search(r"github\.com/.+/.+/archive/.+", url):
> > -            package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable \
> > GitHub archives" % pn, d) +        if \
> > re.search(r"github|gitlab\.com/.+/.+/archive/.+", url): +            \
> > package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub/GitLab \
> > archives, convert recipe to use git protocol" % pn, d) 
> > QARECIPETEST[unhandled-features-check] = \
> > "package_qa_check_unhandled_features_check" def \
> >                 package_qa_check_unhandled_features_check(pn, d, messages):
> > --
> > 2.17.1
> > 
> > 
> > 
> > 


-- 
Regards,
Andrey.



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144041): https://lists.openembedded.org/g/openembedded-core/message/144041
Mute This Topic: https://lists.openembedded.org/mt/77944462/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]