[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
From:       "Denys Zagorui -X (dzagorui - GLOBALLOGIC INC () Cisco) via lists ! openembedded ! org"
Date:       2020-10-30 12:30:30
Message-ID: 1604061028970.9082 () cisco ! com
[Download RAW message or body]

> > .vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
> > It breaks reproducibility because it has an absolute path in it. There is no
> > any value to package such files so it can be dropped.
> >
> 
> Have you confirmed that an on-target 'make scripts prepare' property
> regenerates the file without triggering and oldconfig ?
> 
> Otherwise, the change looks fine to me.
> 
> Bruce

Yes, confirmed that oldconfig wont be triggered.

Thanks,
Denys

> 
> > Signed-off-by: Denys Zagorui <dzagorui@cisco.com>
> > ---
> > meta/recipes-kernel/linux/kernel-devsrc.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > index aa8e162f4f..f8c750beaa 100644
> > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > @@ -113,6 +113,10 @@ do_install() {
> >         # but without this file, we get a forced syncconfig run in v5.8+, which prompts and
> >         # breaks workflows.
> >         cp -a --parents include/generated/autoconf.h $kerneldir/build 2>/dev/null || :
> > +
> > +       if [ -e $kerneldir/include/generated/.vdso-offsets.h.cmd ]; then
> > +           rm $kerneldir/include/generated/.vdso-offsets.h.cmd
> > +       fi
> >      )
> >
> >      # now grab the chunks from the source tree that we need
> > --
> > 2.19.0.dirty
> >
> >
> >
> >


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#143997): https://lists.openembedded.org/g/openembedded-core/message/143997
Mute This Topic: https://lists.openembedded.org/mt/77885275/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]