[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] weston-init: Add environment file support for systemd unit file
From:       "Khem Raj" <raj.khem () gmail ! com>
Date:       2020-09-30 22:46:47
Message-ID: CAMKF1sru9YYgXY3J9dAzAZQe=NRJYsRqsAjk3+FvfoP4UEEFbA () mail ! gmail ! com
[Download RAW message or body]

On Wed, Sep 30, 2020 at 3:19 PM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
> 
> Em qua., 30 de set. de 2020 Ã s 18:55, Khem Raj <raj.khem@gmail.com> escreveu:
> > On Wed, Sep 30, 2020 at 2:41 PM Otavio Salvador
> > <otavio.salvador@ossystems.com.br> wrote:
> > > 
> > > Em qua., 30 de set. de 2020 Ã s 18:31, Khem Raj <raj.khem@gmail.com> escreveu:
> > > > On Wed, Sep 30, 2020 at 2:17 PM Otavio Salvador
> > > > <otavio.salvador@gmail.com> wrote:
> > > > > diff --git a/meta/recipes-graphics/wayland/weston-init/weston@.service \
> > > > > b/meta/recipes-graphics/wayland/weston-init/weston@.service index \
> > > > >                 0a1df15bdf..ce8f4fb71a 100644
> > > > > --- a/meta/recipes-graphics/wayland/weston-init/weston@.service
> > > > > +++ b/meta/recipes-graphics/wayland/weston-init/weston@.service
> > > > > @@ -29,6 +29,7 @@ ConditionPathExists=/dev/tty0
> > > > > [Service]
> > > > > # Requires systemd-notify.so Weston plugin.
> > > > > Type=notify
> > > > > +EnvironmentFile=/etc/default/weston
> > > > 
> > > > Lets make it not fail when not there
> > > > 
> > > > EnvironmentFile=-/etc/default/weston
> > > 
> > > We made it required as it is always installed. So I think it should be
> > > required. How it could not be available?
> > 
> > These are optional environment settings, this will enforce someone to
> > push an empty file if they need to override it instead of just
> > deleting it.
> 
> The point is weston-init[1] always install it as well as the service file.
> 
> 1. https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-graphics/wayland/weston-init.bb#L27
>  
> So it does sounds wrong to allow it to not be there. The recipe
> explicitly adds it in every case.

Hmm so we do install empty file by default. Perhaps then it will work.

> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#142989): https://lists.openembedded.org/g/openembedded-core/message/142989
Mute This Topic: https://lists.openembedded.org/mt/77227403/4454766
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [openembedded-core@marc.info]
-=-=-=-=-=-=-=-=-=-=-=-



[prev in list] [next in list] [prev in thread] [next in thread]