[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] python3-scons: Fix license file collision
From:       Tim Orling <ticotimo () gmail ! com>
Date:       2020-02-29 19:42:55
Message-ID: CANx9H-C=PdOAXZ9eZqXF97c=Pt2Cc9MOAKup9Fb-FPJ9-w2dOw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thank you. It bothered me but I didn't think if this rather simple solution.

On Sat, Feb 29, 2020 at 8:16 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> Downloading a file called "LICENSE" into DL_DIR is 'problematic' and
> collides with the
> file from other versions of the recipe at best.
> 
> Rename it to something more specific to avoid collision problems.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/recipes-devtools/python/python3-scons_3.1.2.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/python/python3-scons_3.1.2.bb
> b/meta/recipes-devtools/python/python3-scons_3.1.2.bb
> index aa7a2a8300d..ce117a92d4f 100644
> --- a/meta/recipes-devtools/python/python3-scons_3.1.2.bb
> +++ b/meta/recipes-devtools/python/python3-scons_3.1.2.bb
> @@ -1,10 +1,10 @@
> SUMMARY = "Software Construction tool (make/autotools replacement)"
> SECTION = "devel/python"
> LICENSE = "MIT"
> -LIC_FILES_CHKSUM =
> "file://${WORKDIR}/LICENSE;md5=e14e1b33428df24a40a782ae142785d0"
> +LIC_FILES_CHKSUM =
> "file://${WORKDIR}/LICENSE-python3-scons-${PV};md5=e14e1b33428df24a40a782ae142785d0"
>  
> # pypi package does not have a valid license file
> -SRC_URI += "
> https://raw.githubusercontent.com/SCons/scons/${PV}/LICENSE;name=license"
> +SRC_URI += "
> https://raw.githubusercontent.com/SCons/scons/${PV}/LICENSE;downloadfilename=LICENSE-python3-scons-${PV};name=license
>  "
> 
> SRC_URI[md5sum] = "f9c4ad06dcf1427be95472eaf380c81a"
> SRC_URI[sha256sum] =
> "8aaa483c303efeb678e6f7c776c8444a482f8ddc3ad891f8b6cdd35264da9a1f"
> --
> 2.25.0
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 


[Attachment #5 (text/html)]

<div><div dir="auto">Thank you. It bothered me but I didn't think if this rather \
simple solution.</div></div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Feb 29, 2020 at 8:16 AM Richard Purdie &lt;<a \
href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Downloading a file called \
&quot;LICENSE&quot; into DL_DIR is &#39;problematic&#39; and collides with the<br> \
file from other versions of the recipe at best.<br> <br>
Rename it to something more specific to avoid collision problems.<br>
<br>
Signed-off-by: Richard Purdie &lt;<a href="mailto:richard.purdie@linuxfoundation.org" \
                target="_blank">richard.purdie@linuxfoundation.org</a>&gt;<br>
---<br>
  meta/recipes-devtools/python/<a href="http://python3-scons_3.1.2.bb" \
rel="noreferrer" target="_blank">python3-scons_3.1.2.bb</a> | 4 ++--<br>  1 file \
changed, 2 insertions(+), 2 deletions(-)<br> <br>
diff --git a/meta/recipes-devtools/python/<a href="http://python3-scons_3.1.2.bb" \
rel="noreferrer" target="_blank">python3-scons_3.1.2.bb</a> \
b/meta/recipes-devtools/python/<a href="http://python3-scons_3.1.2.bb" \
rel="noreferrer" target="_blank">python3-scons_3.1.2.bb</a><br> index \
                aa7a2a8300d..ce117a92d4f 100644<br>
--- a/meta/recipes-devtools/python/<a href="http://python3-scons_3.1.2.bb" \
                rel="noreferrer" target="_blank">python3-scons_3.1.2.bb</a><br>
+++ b/meta/recipes-devtools/python/<a href="http://python3-scons_3.1.2.bb" \
rel="noreferrer" target="_blank">python3-scons_3.1.2.bb</a><br> @@ -1,10 +1,10 @@<br>
  SUMMARY = &quot;Software Construction tool (make/autotools replacement)&quot;<br>
  SECTION = &quot;devel/python&quot;<br>
  LICENSE = &quot;MIT&quot;<br>
-LIC_FILES_CHKSUM = &quot;file://${WORKDIR}/LICENSE;md5=e14e1b33428df24a40a782ae142785d0&quot;<br>
 +LIC_FILES_CHKSUM = \
&quot;file://${WORKDIR}/LICENSE-python3-scons-${PV};md5=e14e1b33428df24a40a782ae142785d0&quot;<br>
 <br>
  # pypi package does not have a valid license file<br>
-SRC_URI += &quot;<a \
href="https://raw.githubusercontent.com/SCons/scons/$%7BPV%7D/LICENSE;name=license" \
rel="noreferrer" target="_blank">https://raw.githubusercontent.com/SCons/scons/${PV}/LICENSE;name=license</a>&quot;<br>
 +SRC_URI += &quot;<a \
href="https://raw.githubusercontent.com/SCons/scons/$%7BPV%7D/LICENSE;downloadfilename=LICENSE-python3-scons-$%7BPV%7D;name=license" \
rel="noreferrer" target="_blank">https://raw.githubusercontent.com/SCons/scons/${PV}/LICENSE;downloadfilename=LICENSE-python3-scons-${PV};name=license</a>&quot;<br>
 <br>
  SRC_URI[md5sum] = &quot;f9c4ad06dcf1427be95472eaf380c81a&quot;<br>
  SRC_URI[sha256sum] = \
                &quot;8aaa483c303efeb678e6f7c776c8444a482f8ddc3ad891f8b6cdd35264da9a1f&quot;<br>
                
-- <br>
2.25.0<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" \
target="_blank">Openembedded-core@lists.openembedded.org</a><br> <a \
href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" \
rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
 </blockquote></div></div>



-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]