[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 01/19] util-linux: Use PCRE for hardlink
From:       Richard Purdie <richard.purdie () linuxfoundation ! org>
Date:       2019-12-30 10:15:22
Message-ID: 7321916d8c3e0fb6fc358d1356b5326a323e062c.camel () linuxfoundation ! org
[Download RAW message or body]

On Sun, 2019-12-29 at 10:43 -0800, Khem Raj wrote:
> Use PCRE, this enables using posix extended Regexps on cmdline
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-core/util-linux/util-linux.inc | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-core/util-linux/util-linux.inc \
> b/meta/recipes-core/util-linux/util-linux.inc index 1fa82363b1..8262217fc1 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -106,6 +106,7 @@ EXTRA_OECONF_append_class-target = " --enable-setpriv"
> EXTRA_OECONF_append_class-native = " --without-cap-ng --disable-setpriv"
> EXTRA_OECONF_append_class-nativesdk = " --without-cap-ng --disable-setpriv"
> 
> +PACKAGECONFIG ?= "pcre2"
> PACKAGECONFIG_class-target ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}"
> # inherit manpages requires this to be present, however util-linux does not have 
> # configuration options, and installs manpages always
> @@ -117,6 +118,8 @@ PACKAGECONFIG[systemd] = "--with-systemd \
> --with-systemdsystemunitdir=${systemd_s PACKAGECONFIG[pylibmount] = \
> "--with-python=3 --enable-pylibmount,--without-python --disable-pylibmount,python3" \
> # Readline support PACKAGECONFIG[readline] = \
> "--with-readline,--without-readline,readline" +# PCRE support in hardlink
> +PACKAGECONFIG[pcre2] = ",,libpcre2"
> 
> EXTRA_OEMAKE = "ARCH=${TARGET_ARCH} CPU= CPUOPT= 'OPT=${CFLAGS}'"

Can we clarify whether this change is meant to be affecting the target
or not (a comment maybe)? At the moment it would only affect
native/nativesdk which I'm fine with, I just want to ensure someone
else doesn't think it was a bug.

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]