[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 2/3] ptest-runner: close all fds in child process.
From:       Richard Purdie <richard.purdie () linuxfoundation ! org>
Date:       2019-05-31 21:50:13
Message-ID: d30ad8bb6247dadd7199cff103f8739ece90af7f.camel () linuxfoundation ! org
[Download RAW message or body]

On Fri, 2019-05-31 at 16:25 -0400, Sakib Sajal wrote:
> When running 'ptest-runner bash', a test named vredir fails
> due to too many open file descriptors.
> The test sets the maximum number of open file descriptors
> to 6 (ulimit -n 6). The test passes by interactively calling
> run-ptest, but not when using ptest-runner.
> Security-focused applications will close all unused file descriptors
> in
> the child after forking but before execing.
> 
> From the failed ptest log:
>    run-vredir
>    87,88c87,88
>    < ./vredir6.sub: line 10: /dev/null: Too many open files
>    < ./vredir6.sub: line 13: /dev/null: Too many open files
>    FAIL: run-vredir
> 
> Upstream-Status: Submitted [yocto@yoctoproject.org]
> 
> Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
> Signed-off-by: Randy Macleod <randy.macleod@windriver.com>

Thanks, this looks like a good fix.

Since I believe Anibal has merged this into the upstream source, could
you send a patch which updates the revision ptest-runner2 is using
instead please? That just then saves adding and then dropping the
patch.

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[prev in list] [next in list] [prev in thread] [next in thread]