[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH] qemu: split out vte into seperate PACKAGECONFIG
From:       Andreas Müller <schnitzeltony () gmail ! com>
Date:       2019-04-30 13:19:27
Message-ID: 20190430131927.29493-1-schnitzeltony () gmail ! com
[Download RAW message or body]

* vte-native requires host compiler supporting c++17. Some distros we support
  ship comilers not supporting c++17 currently.
* oe-self-test 'test_testimage_virgl_gtk' sets
  PACKAGECONFIG_append_pn-qemu-system-native = " gtk+". With vte enabled by
  'gtk+'-config, build fails on hosts with ancient compilers [1].
* Alexander Kanavin did some tests: Without vte in PACKAGECONFIG there is still
  a working terminal available with reduced functionality [2].
* Users wanting 'full' terminal in system-qemu back should add
  PACKAGECONFIG_append_pn-qemu-system-native = " vte"
  in their local.conf.

The idea of this patch was coming from Ross Burton - thanks!

[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/281637.html
[2] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/281727.html

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-devtools/qemu/qemu.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index 13f0549c25..3ec141452d 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -144,7 +144,8 @@ PACKAGECONFIG[vnc-png] = "--enable-vnc --enable-vnc-png,--disable-vnc-png,libpng
 PACKAGECONFIG[libcurl] = "--enable-curl,--disable-curl,libcurl,"
 PACKAGECONFIG[nss] = "--enable-smartcard,--disable-smartcard,nss,"
 PACKAGECONFIG[curses] = "--enable-curses,--disable-curses,ncurses,"
-PACKAGECONFIG[gtk+] = "--enable-gtk --enable-vte,--disable-gtk --disable-vte,gtk+3 vte gettext-native"
+PACKAGECONFIG[gtk+] = "--enable-gtk,--disable-gtk,gtk+3 gettext-native"
+PACKAGECONFIG[vte] = "--enable-vte,--disable-vte,vte gettext-native"
 PACKAGECONFIG[libcap-ng] = "--enable-cap-ng,--disable-cap-ng,libcap-ng,"
 PACKAGECONFIG[ssh2] = "--enable-libssh2,--disable-libssh2,libssh2,"
 PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt,"
-- 
2.20.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[prev in list] [next in list] [prev in thread] [next in thread]