[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] npm: change install directory to upstream default
From:       Dan McGregor <danismostlikely () gmail ! com>
Date:       2018-10-31 16:38:00
Message-ID: CACS+7ZQk2k0-xc0P1mkjf_690CepGvynJoTck_Ggn5dUMaaRkw () mail ! gmail ! com
[Download RAW message or body]

On Mon, 29 Oct 2018 at 04:39, Olaf Mandel <o.mandel@menlosystems.com> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hello Dan,
>
> Am 26.10.2018 um 19:46 schrieb Dan McGregor:
> > On Fri, 19 Oct 2018 at 09:29, Olaf Mandel
> > <o.mandel@menlosystems.com> wrote:
> >> -NPM_INSTALLDIR = "${D}${libdir}/node_modules/${NPMPN}"
> >> +NPM_INSTALLDIR = "${D}${libdir}/node/${NPMPN}"
> >
> > Ï realise this has already gone în, but should this be
> > ${nonarch_libdir}, or does it use /usr/lib64 or /usr/libx32
> > correctly?
> >
> For me, libdir resolves to /usr/lib, so I didn't notice any problems.
> And the "lib"-part is hardcoded in NodeJS (lib/module.js:
> path.resolve(prefixDir, 'lib', 'node')).
>
> So if ${nonarch_libdir} is always ${prefix}/lib even if ${libdir}
> isn't, then that should be changed.

Okay, that makes sense. The behaviour of nonarch_libdir is as you
described, sp on certain targets (ie x86_64 or aarch64) with multilib
enabled ${libdir} would resolve to /usr/lib64.

>
> Best regards,
> Olaf Mandel
> -----BEGIN PGP SIGNATURE-----
>
> iQEzBAEBCAAdFiEErGOsr28GGMKRE/TmVL2dtGJSHf8FAlvW43UACgkQVL2dtGJS
> Hf8gLAf/aIQ5z219f1Tqtp5Oc1mBr4IN3T/Uzk6MlKKtqfQGS2KBF7CqWLUKNXT2
> /eKa/v7H55yTWC6PSlJjx7HMzJK9mhwZ84LwAQ4rpj6ZBn1RYjv4DBdgPxlQN+1N
> 4kAoWklpgBut0eNtb9hniwf2VhF7rkI8eLVdNcL1SR7JroDahSnjVGozuE/asxK0
> yJHHaz3cbe6QooYKeyi4y6lM1wJfP5Wny0rOCMh3rWvsexf7G7itki0MoRU7dNVv
> C2zK+/KVjhYbLWSRijSYjGRFpMzKb9AddBxkpIZ4z7vjAlbbbYN1iw3RdPoiPYhP
> rwvtSk3Wwe4McsVUjRaEFxwcdCPQQQ==
> =1BcQ
> -----END PGP SIGNATURE-----
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[prev in list] [next in list] [prev in thread] [next in thread]