[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONF
From:       Bruce Ashfield <bruce.ashfield () windriver ! com>
Date:       2018-10-30 20:07:19
Message-ID: 0a2e2424-f3f6-ac8e-93eb-794c17efe661 () windriver ! com
[Download RAW message or body]

On 2018-10-30 3:46 PM, Andre McCurdy wrote:
> On Tue, Oct 30, 2018 at 12:05 PM Bruce Ashfield
> <bruce.ashfield@windriver.com> wrote:
> > 
> > As was warned by commit 312ee68752fa [kconfig: announce removal of
> > oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.
> > 
> > So we switch our default mode to olddefconfig.
> > 
> > commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',
> > and keep the old name as an alias] introduced olddefconfig in the 3.10
> > kernel, we shuffle oldnoconfig to the fallback target.
> > 
> > The fallback mode allows kernels between 3.10 and the currently listed
> > oldest kernel of 3.2 to continue to configure.
> > 
> > Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> > ---
> > 
> > v3: dropped 'yes' from the pipeline
> > 
> > v2: Tweaked to add a fallback mode as suggested by Andre McCurdy
> > 
> > Not for the release, just wanted to get this in the queue for
> > when master reopens so we'll be ready for 4.20+ kernel versions
> > 
> > Tested by configuring linux-yocto*
> > 
> > Bruce
> > 
> > 
> > meta/classes/kernel.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index e04d2fe00434..880c5ef17283 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -492,7 +492,7 @@ sysroot_stage_all () {
> > > 
> > }
> > 
> > -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} \
> > oldnoconfig" +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" \
> > O=${B} olddefconfig || oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig"
> 
> Apart from inexplicably swapping the positions of the O= and CC=
> options on the fallback command line (?!?), this version looks good.

never noticed :) I just cut and pasted it differently. I'll spare
everyone a v4 for that!

Bruce

> 
> > python check_oldest_kernel() {
> > oldest_kernel = d.getVar('OLDEST_KERNEL')
> > --
> > 2.5.0
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]