[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [OE-Core][PATCH] sudo: Add missing dep on virtual/crypt
From:       "Burton, Ross" <ross.burton () intel ! com>
Date:       2018-08-31 9:58:28
Message-ID: CAJTo0LaBhtM=jPYeOLMsfsmPyc23CyJg=D3ivx9q-LufJrwStA () mail ! gmail ! com
[Download RAW message or body]

Yeah, that sounds right.

Ross

On 31 August 2018 at 08:18, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> I have to admit, I didn't look, I just assumed it was working for the
> pam case, since I don't have a build which needs pam.
> 
> Looking at the sudo code/libpam, it looks like you need it, but you'd
> get it through transitive dependencies - should we just add it
> unconditionally here?
> 
> On Thu, Aug 30, 2018 at 9:52 PM Burton, Ross <ross.burton@intel.com> wrote:
> > 
> > That suggests that the crypt dependency is only needed if pam is
> > disabled, is that the case?
> > 
> > Ross
> > 
> > On 30 August 2018 at 09:34, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> > > Ensure we have virtual/crypt even if building without PAM; fixes:
> > > 
> > > sudo: error in /etc/sudo.conf, line 0 while loading plugin "sudoers_policy"
> > > sudo: unable to load /usr/libexec/sudo/sudoers.so: \
> > >                 /usr/libexec/sudo/sudoers.so: undefined symbol: crypt
> > > sudo: fatal error, unable to load plugins
> > > 
> > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> > > ---
> > > 
> > > meta/recipes-extended/sudo/sudo_1.8.23.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-extended/sudo/sudo_1.8.23.bb \
> > > b/meta/recipes-extended/sudo/sudo_1.8.23.bb index ab9c8cb..18add22 100644
> > > --- a/meta/recipes-extended/sudo/sudo_1.8.23.bb
> > > +++ b/meta/recipes-extended/sudo/sudo_1.8.23.bb
> > > @@ -10,7 +10,7 @@ PAM_SRC_URI = "file://sudo.pam"
> > > SRC_URI[md5sum] = "ea444d747feb1decfebdffd0b38b0739"
> > > SRC_URI[sha256sum] = \
> > > "d863d29b6fc87bc784a3223350e2b28a2ff2c4738f0fb8f1c92bb38c3017e679" 
> > > -DEPENDS += " ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
> > > +DEPENDS += " ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'libpam', \
> > > 'virtual/crypt', d)}" RDEPENDS_${PN} += " \
> > > ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam-plugin-limits \
> > > pam-plugin-keyinit', '', d)}" 
> > > EXTRA_OECONF += " \
> > > --
> > > 2.7.4
> > > 
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> 
> --
> Alex Kiernan
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]