[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] util-linux.inc: add fallocate only for class-target
From:       Richard Purdie <richard.purdie () linuxfoundation ! org>
Date:       2018-07-31 12:12:26
Message-ID: 05364d3e846c658144c944bce82d7b3ec252356e.camel () linuxfoundation ! org
[Download RAW message or body]

On Fri, 2018-07-27 at 12:05 +0100, Burton, Ross wrote:
> On 27 July 2018 at 00:58, Andre McCurdy <armccurdy@gmail.com> wrote:
> > On Thu, Jul 26, 2018 at 4:34 PM, Burton, Ross <ross.burton@intel.co
> > m> wrote:
> > > On 26 July 2018 at 14:58, Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> > > wrote:
> > > > Because the util-linux_2.32.bb recipe explicitely disables
> > > > fallocate
> > > > for nativesdk triggering build warnings:
> > > 
> > > Does anyone know why util-linux disables fallocate for nativesdk
> > > and
> > > native builds?
> > 
> > Seems to date back to this commit:
> > 
> >   http://git.openembedded.org/openembedded-core/commit/?id=17f3c548
> > caf4adec37c3bbb139aa6b3900419794
> > 
> >   +# fallocate is glibc 2.10, fallocate64 is glibc 2.11
> >   +# we need to disable it for older versions
> >   +EXTRA_OECONF += "ac_cv_func_fallocate=no"
> >   +EXTRA_OECONF_virtclass-native += "--disable-fallocate
> > --disable-use-tty-group"
> 
> Well done, it was late and I got bored following the git-blame
> log.  :)
> 
> Sounds like historical reasons to me, does anyone object to dropping
> this?

No, I think this predates uninative...

Cheers,

Richard


-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[prev in list] [next in list] [prev in thread] [next in thread]