[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH] oe.types.boolean: treat None as False
From:       Binghua Guan <freebendy () gmail ! com>
Date:       2018-06-30 9:53:34
Message-ID: 1530352414-13342-1-git-send-email-freebendy () gmail ! com
[Download RAW message or body]

It is better to return False for None. E.g. checking an undefined
variable returned d.getVar().

Signed-off-by: Binghua Guan <freebendy@gmail.com>
---
 meta/lib/oe/types.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oe/types.py b/meta/lib/oe/types.py
index f778c1d..f401713 100644
--- a/meta/lib/oe/types.py
+++ b/meta/lib/oe/types.py
@@ -103,8 +103,11 @@ def boolean(value):
     """OpenEmbedded 'boolean' type
 
     Valid values for true: 'yes', 'y', 'true', 't', '1'
-    Valid values for false: 'no', 'n', 'false', 'f', '0'
+    Valid values for false: 'no', 'n', 'false', 'f', '0', None
     """
+    if value is None:
+        return False
+
     if isinstance(value, bool):
         return value
 
-- 
2.7.4

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[prev in list] [next in list] [prev in thread] [next in thread]