[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 13/14] testimage-auto.bbclass: execute the same codes as testimage task
From:       Alexander Kanavin <alex.kanavin () gmail ! com>
Date:       2018-05-31 13:50:19
Message-ID: CANNYZj_JiC4h8s7oqgrw_Faq-2K2Hm64Zy0ZjfdBvQCdWAB7cQ () mail ! gmail ! com
[Download RAW message or body]

2018-05-31 11:45 GMT+03:00 Chen Qi <Qi.Chen@windriver.com>:
>  python do_testimage_auto() {
> +    testimage_sanity(d)
> +
> +    if (d.getVar('IMAGE_PKGTYPE') == 'rpm'
> +       and ('dnf' in d.getVar('TEST_SUITES') or 'auto' in d.getVar('TEST_SUITES'))):
> +        create_rpm_index(d)
> +
>      testimage_main(d)

Why not simply move these lines to testimage_main()? They might become
out of sync again in the future otherwise.

Alex
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[prev in list] [next in list] [prev in thread] [next in thread]