[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 1/1] i2c-tools: fix libdir for multilib
From:       "Burton, Ross" <ross.burton () intel ! com>
Date:       2018-01-31 11:31:16
Message-ID: CAJTo0LZeSbYU4KqF2ryZhmNHmpZ6xPTFS0B+RgunJjSygaT7Hg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 31 January 2018 at 09:44, <kai.kang@windriver.com> wrote:

>  inherit autotools-brokensep
>
> +EXTRA_OEMAKE = "libdir=${libdir}"
> +
>  do_compile_prepend() {
>      sed -i 's#/usr/local#/usr#' ${S}/Makefile
>      echo "include eeprog/Module.mk" >> ${S}/Makefile
>

The context of autotools-brokensep and seding of the Makefile made me
suspicious, so I'm rejecting this patch because I've just rewritten the
entire recipe...  :)

Ross

[Attachment #5 (text/html)]

<div dir="ltr">On 31 January 2018 at 09:44,  <span dir="ltr">&lt;<a \
href="mailto:kai.kang@windriver.com" \
target="_blank">kai.kang@windriver.com</a>&gt;</span> wrote:<br><div \
class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  inherit \
autotools-brokensep<br> <br>
+EXTRA_OEMAKE = &quot;libdir=${libdir}&quot;<br>
+<br>
  do_compile_prepend() {<br>
        sed -i &#39;s#/usr/local#/usr#&#39; ${S}/Makefile<br>
        echo &quot;include eeprog/Module.mk&quot; &gt;&gt; \
${S}/Makefile<br></blockquote><div><br></div><div>The context of autotools-brokensep \
and seding of the Makefile made me suspicious, so I&#39;m rejecting this patch \
because I&#39;ve just rewritten the entire recipe...   \
:)</div><div><br></div><div>Ross  </div></div></div></div>



-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]