[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] About auto-upgrade-helper's enhancement
From:       Robert Yang <liezhi.yang () windriver ! com>
Date:       2017-11-30 8:18:18
Message-ID: 5f54d36b-a2c2-e667-538b-786e440b48b0 () windriver ! com
[Download RAW message or body]

Hi Alexander,

On 11/30/2017 03:18 PM, Alexander Kanavin wrote:
> On 11/30/2017 04:23 AM, Robert Yang wrote:
>> I tried auto-upgrade-helper, it is very helpful when upgrade recipes.
>> I'd like to make some enhancements to make it can be easily used by the
>> maintainer (recipe upgrader) himself:
> 
> Great, let's make it awesome :)
> 
>> 1) Don't send email when maintainer uses it, for example, when I want to
>>     upgrade "strace", I don't need it send email to anyone.
> 
> I think email sending can be easily disabled in the configuration, no?

I'm not sure, this is the first time that I use AUH, but I really like it.

> 
>> 2) Use git's user.name and user.email in git commit when not send email,
>>     we need let the maintainer take responsible for it.
> 
> You can reset the commit authorship via 'git commit --amend --reset-author', but 
> I wouldn't want automatically created commits to have my name by default, 
> especially when mass-creating them.

Yes, maybe it can read author from conf file, use git's user and email when not 
fonud in conf file.

I will send draft patches later.

// Robert

> 
>> 3) Do the commit on the recipes when the upgrade is succeed, currently,
>>     it keeps the commit when failed, but removed it when succeed.
> 
> Yes. In fact I've deleted all code that does branch and commit manipulation, 
> except the part that creates commits. The tool shouldn't decide for the user how 
> to manage branches, and on which branch to base the work (currently hardcoded to 
> master) etc.
> 
>> 4) Make upgradehelper.py can accept multiple recipes as args.
> 
> Yep.
> 
>> 5) It's a small tool and helpful when upgrade recipes, can we move it into
>>     oe-core/scripts, please ?
> 
> I agree, after it's been ported to use devtool and I'm happy with how it works.
> 
> Alex
> 
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[prev in list] [next in list] [prev in thread] [next in thread]