[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 03/13] devtool: upgrade: check that user has configured git properly
From:       Paul Eggleton <paul.eggleton () linux ! intel ! com>
Date:       2017-08-31 21:01:53
Message-ID: 2289008.Qv25xzknfF () peggleto-mobl ! ger ! corp ! intel ! com
[Download RAW message or body]

On Friday, 1 September 2017 1:29:38 AM NZST Burton, Ross wrote:
> On 31 August 2017 at 00:54, Paul Eggleton <paul.eggleton@linux.intel.com>
> wrote:
> 
> > From: paul <paul@peggleto-mobl.ger.corp.intel.com>
> >
> > If user.name or user.email haven't been set then git rebase can't really
> > work properly. Check that the user has set these and error out if not.
> > (Elsewhere we are relying on OE's git patch functionality which forces
> > a dummy OE value - that's OK there as it's completely under OE's control
> > and therefore it's OK for a dummy OE user to be the committer, but here
> > the rebase may require intervention so it's reasonable to have the
> > user's actual name and email on the operation.)
> >
> 
> The irony is strong in this one.
> 
> (I'll fixup when merging)

Shoot. Of course I committed the change just after I'd cleared out the 
settings to test the darn thing ;)

Cheers,
Paul


-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[prev in list] [next in list] [prev in thread] [next in thread]