'Re: [OE-core] [PATCH 2/2] iproute2: enable build tipc by default'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 2/2] iproute2: enable build tipc by default
From:       Yi Zhao <yi.zhao () windriver ! com>
Date:       2017-08-31 0:53:18
Message-ID: 4b1e1cc4-3e18-e81d-9ddd-aa176ee01749 () windriver ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

在 2017年08月30日 15:43, Jussi Kukkonen 写道:
> On 30 August 2017 at 03:35, Yi Zhao <yi.zhao@windriver.com 
> <mailto:yi.zhao@windriver.com>> wrote:
>
>
>
>     在 2017年08月30日 00:13, Burton, Ross 写道:
>>     On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com
>>     <mailto:yi.zhao@windriver.com>> wrote:
>>
>>         -PACKAGECONFIG ??= ""
>>         -PACKAGECONFIG[tipc] = ",,libmnl,"
>>
>>
>>     Surely it would be a lot better to just add tipc to the default
>>     PACKAGECONFIG, so this support and dependencies can be turned off
>>     if required?
>
>     There is no easy way to turn off the support with this patch. User
>     should remove tipc from EXTRA_OEMAKE manually.
>     The package isn't installed to rootfs by default if no package
>     requires it.
>
>
> The question is why not leave the PACKAGECONFIG there so there would 
> be an easy way to turn it off?

I just thought this would make the code more clear. The source doesn't 
build with autotools,  PACKAGECONFIG[tipc] = ",,libmnl," looks a little 
strange.
If it is not a good idea, I will send a v2 patch to keep the PACKAGECONFIG.

Thanks,
Yi

>
> Jussi

[Attachment #5 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">在 2017年08月30日 15:43, Jussi Kukkonen 写道:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAHiDW_HXpZOhODj0=0xyV9EJLdYcO-g4e-Cye3U-vzNSiWMjcQ@mail.gmail.com">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">On 30 August 2017 at 03:35, Yi Zhao <span
              dir="ltr">&lt;<a href="mailto:yi.zhao@windriver.com"
                target="_blank" moz-do-not-send="true">yi.zhao@windriver.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF"><span class="">
                  <p><br>
                  </p>
                  <br>
                  <div class="m_-2270919719305798428moz-cite-prefix">在
                    2017年08月30日 00:13, Burton, Ross 写道:<br>
                  </div>
                  <blockquote type="cite">
                    <div dir="ltr">On 29 August 2017 at 08:25, Yi Zhao <span
                        dir="ltr">&lt;<a
                          href="mailto:yi.zhao@windriver.com"
                          target="_blank" moz-do-not-send="true">yi.zhao@windriver.com</a>&gt;</span>
                      wrote:
                      <div class="gmail_extra">
                        <div class="gmail_quote">
                          <blockquote class="gmail_quote"
                            style="margin:0 0 0 .8ex;border-left:1px
                            #ccc solid;padding-left:1ex"> -PACKAGECONFIG
                            ??= ""<br>
                            -PACKAGECONFIG[tipc] = ",,libmnl,"<br>
                          </blockquote>
                          <div><br>
                          </div>
                          <div>Surely it would be a lot better to just
                            add tipc to the default PACKAGECONFIG, so
                            this support and dependencies can be turned
                            off if required?</div>
                        </div>
                      </div>
                    </div>
                  </blockquote>
                  <br>
                </span> There is no easy way to turn off the support
                with this patch. User should remove tipc from
                EXTRA_OEMAKE manually.<br>
                The package isn't installed to rootfs by default if no
                package requires it.<br>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>The question is why not leave the PACKAGECONFIG there
              so there would be an easy way to turn it off? <br>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    I just thought this would make the code more clear. The source
    doesn't build with autotools,   PACKAGECONFIG[tipc] = ",,libmnl,"
    looks a little strange. <br>
    If it is not a good idea, I will send a v2 patch to keep the
    PACKAGECONFIG.<br>
    <br>
    Thanks,<br>
    Yi<br>
    <br>
    <br>
    <blockquote type="cite"
cite="mid:CAHiDW_HXpZOhODj0=0xyV9EJLdYcO-g4e-Cye3U-vzNSiWMjcQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">
            <div><br>
            </div>
            <div>Jussi</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[prev in list] [next in list] [prev in thread] [next in thread] 