[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] Check if /etc/fstab exists
From:       "Tamtamis, Panagiotis" <panagiotis.tamtamis () unify ! com>
Date:       2017-04-28 9:32:10
Message-ID: 0D74DA672F03634EA90EB18A61E36D272639CC1D () MCHP04MSX ! global-ad ! net
[Download RAW message or body]

> -----Original Message-----
> From: Andre McCurdy [mailto:armccurdy@gmail.com]
> Sent: Thursday, April 27, 2017 9:56 PM
> To: Tamtamis, Panagiotis
> Cc: OE Core mailing list
> Subject: Re: [OE-core] [PATCH] Check if /etc/fstab exists
> 
> On Thu, Apr 27, 2017 at 9:56 AM, Panagiotis Tamtamis
> <panagiotis.tamtamis@unify.com> wrote:
> > Using "read-only-rootfs" feature in minimal or special purpose images
> > (eg mounted images) makes build to fail because
> > ${IMAGE_ROOTFS}/etc/fstab file does not exist.
> >
> > Signed-off-by: Panagiotis Tamtamis <panagiotis.tamtamis@unify.com>
> > ---
> >  meta/classes/rootfs-postcommands.bbclass | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/rootfs-postcommands.bbclass
> > b/meta/classes/rootfs-postcommands.bbclass
> > index 0c7ceea..4709369 100644
> > --- a/meta/classes/rootfs-postcommands.bbclass
> > +++ b/meta/classes/rootfs-postcommands.bbclass
> > @@ -64,7 +64,8 @@ systemd_create_users () {  #  read_only_rootfs_hook
> > () {
> >         # Tweak the mount option and fs_passno for rootfs in fstab
> > -       sed -i -e
> '/^[#[:space:]]*\/dev\/root/{s/defaults/ro/;s/\([[:space:]]*[[:digit:]]\)\([[:sp
> ace:]]*\)[[:digit:]]$/\1\20/}' ${IMAGE_ROOTFS}/etc/fstab
> > +       if [ -f ${IMAGE_ROOTFS}/etc/fstab ]; then
> > +               sed -i -e
> > + '/^[#[:space:]]*\/dev\/root/{s/defaults/ro/;s/\([[:space:]]*[[:digit
> > + :]]\)\([[:space:]]*\)[[:digit:]]$/\1\20/}' ${IMAGE_ROOTFS}/etc/fstab
> 
> Missing "fi" ?

Thanks, fix with:
http://lists.openembedded.org/pipermail/openembedded-core/2017-April/136171.html
First patch had also wrong shortlog.

> 
> >
> >         # If we're using openssh and the /etc/ssh directory has no pre-
> generated keys,
> >         # we should configure openssh to use the configuration file
> > /etc/ssh/sshd_config_readonly
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[prev in list] [next in list] [prev in thread] [next in thread]