[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH v2 0/1] kexec-tools: Upgrade to 2.0.14
From:       He Zhe <zhe.he () windriver ! com>
Date:       2016-12-29 2:05:38
Message-ID: afdc76ed-6600-6292-c927-89e240a0e325 () windriver ! com
[Download RAW message or body]



On 12/28/2016 08:15 PM, Alexander Kanavin wrote:
> On 12/27/2016 08:43 AM, zhe.he@windriver.com wrote:
> > From: He Zhe <zhe.he@windriver.com>
> > 
> > Remove kexec-aarch64.patch since it has been merged upstream
> > Remove kexec-x32.patch since it has been reverted upstream
> > Backport patches for kdump arm64 from:
> > https://git.linaro.org/people/takahiro.akashi/kexec-tools.git
> > 
> > v1 to v2: Remove redundant tarball link in SRC_URI
> 
> None of my comments are addressed in this new version of the patch. Specifically:
> 
> > Remove kexec-aarch64.patch since it has been merged upstream
> > Remove kexec-x32.patch since it has been reverted upstream
> 
> You should also remove the actual files, not just drop them from the recipe.
> 
> > Backport patches for kdump arm64 from:
> > https://git.linaro.org/people/takahiro.akashi/kexec-tools.git
> 
> If the patches are coming from a different repository, they are not a backport. \
> Change the upstream-status to 'pending' please, or 'submitted (link)' if they have \
> been submitted upstream. 
> > meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb    |  37 ----
> > meta/recipes-kernel/kexec/kexec-tools_2.0.14.bb    |  44 +++++
> 
> Please use git's rename detection when submitting patches, so we can see what is \
> the difference between the two files. 

Thank you for your careful review. Sorry for missing your comments for v1 since I \
just filter mails specifically sent to me... I'll send v3 soon.

Thanks,
Zhe

> 
> Alex
> 
> 

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]