[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH v2] uninative: rebuild uninative for gcc 4.8 and 4.9
From:       "Burton, Ross" <ross.burton () intel ! com>
Date:       2016-10-31 20:11:36
Message-ID: CAJTo0LbZ=dQWK7XyUOz5My8iKje8DYgCMmkLPCTXeEicWoj9xg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 27 October 2016 at 08:10, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:

> +    match = re.match(".* (\d\.\d)\.\d .*", output.split('\n')[0])
>

Debian uses this string:

gcc (Debian 4.9.2-10) 4.9.2

So your regex needs to be a bit more permissive, and it looks like grabbing
the second number would be more appropriate here too.

Ross

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 27 October \
2016 at 08:10, Ed Bartosh <span dir="ltr">&lt;<a \
href="mailto:ed.bartosh@linux.intel.com" \
target="_blank">ed.bartosh@linux.intel.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
id="gmail-:3fu" class="gmail-a3s gmail-aXjCH gmail-m15804ff93a44e9dd">+      match = \
re.match(&quot;.* (\d\.\d)\.\d .*&quot;, \
output.split(&#39;\n&#39;)[0])<br></div></blockquote></div><div \
class="gmail_extra"><br></div>Debian uses this string:</div><div \
class="gmail_extra"><br>gcc (Debian 4.9.2-10) 4.9.2<br></div><div \
class="gmail_extra"><br></div><div class="gmail_extra">So your regex needs to be a \
bit more permissive, and it looks like grabbing the second number would be more \
appropriate here too.</div><div class="gmail_extra"><br></div><div \
class="gmail_extra">Ross</div></div>



-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]