[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH 4/7] devtool: finish: warn if moving recipe to unconfigured destination layer
From:       Paul Eggleton <paul.eggleton () linux ! intel ! com>
Date:       2016-10-31 3:59:46
Message-ID: 299bdc10f6f62885565d15669097dae33cc60081.1477886344.git.paul.eggleton () linux ! intel ! com
[Download RAW message or body]

If you run devtool finish to move a recipe created in the workspace by
devtool add or devtool upgrade to a layer, and that layer is not
currently included in bblayers.conf (perhaps unintentionally), then the
recipe will no longer be visible to bitbake. In this scenario, show a
warning so that the user isn't surprised by the recipe "going missing".

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 scripts/lib/devtool/standard.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 9511d56..c15bfef 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -1517,6 +1517,11 @@ def finish(args, config, basepath, workspace):
             destpath = oe.recipeutils.get_bbfile_path(rd, destlayerdir, origrelpath)
             if not destpath:
                 raise DevtoolError("Unable to determine destination layer path - \
check that %s specifies an actual layer and %s/conf/layer.conf specifies BBFILES. You \
may also need to specify a more complete path." % (args.destination, destlayerdir)) + \
# Warn if the layer isn't in bblayers.conf (the code to create a bbappend will do \
this in other cases) +            layerdirs = [os.path.abspath(layerdir) for layerdir \
in rd.getVar('BBLAYERS', True).split()] +            if not \
os.path.abspath(destlayerdir) in layerdirs: +                bb.warn('Specified \
destination layer is not currently enabled in bblayers.conf, so the %s recipe will \
now be unavailable in your current configuration until you add the layer there' % \
args.recipename) +
         elif destlayerdir == origlayerdir:
             # Same layer, update the original recipe
             appendlayerdir = None
-- 
2.5.5

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]