[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH 1/3] subprocess: remove strings and migrate to direct arrays
From:       "Burton, Ross" <ross.burton () intel ! com>
Date:       2016-09-30 16:10:46
Message-ID: CAJTo0LY1H2PmjEPAi+un0WYYEkXPvUzVkQ6HBic_L++TceuUyg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 29 September 2016 at 22:34, Stephano Cetola <
stephano.cetola@linux.intel.com> wrote:

> -        cmd = "%s %s query --output %s" %  \
> -              (self.smart_cmd, self.smart_opt, available_manifest)
> +        cmd = [self.smart_cmd, self.smart_opt, 'query', '--output',
> available_manifest]
>

self.smart_opt is a string containing many options, so this needs to be
transformed to a list of options and embedded correctly.

Ross

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 29 September \
2016 at 22:34, Stephano Cetola <span dir="ltr">&lt;<a \
href="mailto:stephano.cetola@linux.intel.com" \
target="_blank">stephano.cetola@linux.intel.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
id="gmail-:ph" class="gmail-a3s gmail-aXjCH gmail-m15777e152b9da4e7"><span \
style="font-size:12.800000190734863px">-            cmd = &quot;%s %s query --output \
%s&quot; %   \</span><br style="font-size:12.800000190734863px"><span \
style="font-size:12.800000190734863px">-                     (self.smart_cmd, \
self.smart_opt, available_manifest)</span><br \
style="font-size:12.800000190734863px"><span style="font-size:12.800000190734863px">+ \
cmd = [self.smart_cmd, self.smart_opt, &#39;query&#39;, &#39;--output&#39;, \
available_manifest]</span></div></blockquote><div><br></div><div>self.smart_opt is a \
string containing many options, so this needs to be transformed to a list of options \
and embedded correctly.</div><div><br></div><div>Ross  </div></div></div></div>



-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]