[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    Re: [OE-core] [PATCH] init-install*: /etc/mtab make a link rather than a copy
From:       Khem Raj <raj.khem () gmail ! com>
Date:       2016-07-29 18:35:59
Message-ID: 8810C6FB-7CB4-4648-B8B5-A9199C3468CB () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


> On Jul 29, 2016, at 3:17 AM, Belal, Awais <Awais_Belal@mentor.com> wrote:
> 
> > > On Jul 28, 2016, at 1:49 AM, Awais Belal <awais_belal@mentor.com> wrote:
> > > 
> > > Using a copy would only make management of devices erroneous
> > > and makes the system unstable in some scenarios as tools will
> > > have to manipulate both files separately. A link ensures that
> > > both files /proc/mounts and /etc/mtab will have the same
> > > information at all times and this is how it is handled
> > > on newer systems where there is such a need. Same is
> > > suggested by busybox.
> > > 
> > > Signed-off-by: Awais Belal <awais_belal@mentor.com>
> > > ---
> > > meta/recipes-core/initrdscripts/files/init-install-efi.sh | 2 +-
> > > meta/recipes-core/initrdscripts/files/init-install.sh     | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/meta/recipes-core/initrdscripts/files/init-install-efi.sh \
> > > b/meta/recipes-core/initrdscripts/files/init-install-efi.sh index \
> > >                 f564f4e..53f6508 100644
> > > --- a/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> > > +++ b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> > > @@ -123,7 +123,7 @@ mkdir -p /tmp
> > > 
> > > # Create /etc/mtab if not present
> > > if [ ! -e /etc/mtab ]; then
> > > -    cat /proc/mounts > /etc/mtab
> > > +    ln -sf /etc/mtab /proc/mounts
> > > fi
> 
> > I think this does not consider the case where procfs may be disabled in kernel. \
> > Is there such a possibility ?
> 
> Well in such a case at least mtab should be available so the link won't be created.

we are checking for /etc/mtab and not /proc/mtab so no.
Secondly, it seems the symlink needs to be reversed.

> 
> > > 
> > > disk_size=$(parted ${device} unit mb print | grep '^Disk .*: .*MB' | cut -d" " \
> > >                 -f 3 | sed -e "s/MB//")
> > > diff --git a/meta/recipes-core/initrdscripts/files/init-install.sh \
> > > b/meta/recipes-core/initrdscripts/files/init-install.sh index 72ce92b..21ae0a6 \
> > >                 100644
> > > --- a/meta/recipes-core/initrdscripts/files/init-install.sh
> > > +++ b/meta/recipes-core/initrdscripts/files/init-install.sh
> > > @@ -119,7 +119,7 @@ fi
> > > 
> > > mkdir -p /tmp
> > > if [ ! -L /etc/mtab ]; then
> > > -    cat /proc/mounts > /etc/mtab
> > > +    ln -sf /etc/mtab /proc/mounts
> > > fi
> > > 
> > > disk_size=$(parted ${device} unit mb print | grep '^Disk .*: .*MB' | cut -d" " \
> > >                 -f 3 | sed -e "s/MB//")
> > > --
> > > 1.9.1
> > > 
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> BR,
> Awais


["signature.asc" (signature.asc)]

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iEYEARECAAYFAlebohMACgkQuwUzVZGdMxTzOwCggpIW0lJhas2lgOV/Ei79+zMA
AwkAoJOe2Xtb33B5Wr05mvHjhNoY5a7f
=hh1c
-----END PGP SIGNATURE-----


-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[prev in list] [next in list] [prev in thread] [next in thread]