[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH 4/5] glibc.inc: do not immediate expand SELECTED_OPTIMIZATION
From:       pb () pbcl ! net (Phil Blundell)
Date:       2016-01-30 10:35:58
Message-ID: 1454150158.7421.5.camel () pbcl ! net
[Download RAW message or body]

On Fri, 2016-01-29 at 12:35 -0500, Hongxu Jia wrote:
> We need to expand SELECTED_OPTIMIZATION later, so
> do not immediate expansion, and do the work in
> anonymous python function.
> 
> It is reasonable to give an error for -O0.

I applaud the general idea of this patch, but...

> +        d.appendVar("SELECTED_OPTIMIZATION", " -Wno-error")

... can't you just use CFLAGS += -Wno-error rather than fiddling with
SELECTED_OPTIMIZATION here?  -Wno-error is clearly not an optimization
flag.

p.



[prev in list] [next in list] [prev in thread] [next in thread]