[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH] gstreamer-omx: Improve variable expansion of ${S}
From:       richard.purdie () linuxfoundation ! org (Richard Purdie)
Date:       2015-09-30 13:53:51
Message-ID: 1443621231.5162.94.camel () linuxfoundation ! org
[Download RAW message or body]

The way ${S} is expanded into CFLAGS means the recipe is marked as depending
on the path within which its built. We can avoid this by avoiding the expansion
which then allows reuse of the recipe from sstate.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc \
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc index 8c273fc..6806455 \
                100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
@@ -20,11 +20,10 @@ EXTRA_OECONF += "--disable-valgrind \
--with-omx-target=${GSTREAMER_1_0_OMX_TARGET  python __anonymous () {
     omx_target = d.getVar("GSTREAMER_1_0_OMX_TARGET", True)
     if omx_target in ['generic', 'bellagio']:
-        srcdir = d.getVar("S", True)
         # Bellagio headers are incomplete (they are missing the OMX_VERSION_MAJOR,#
         # OMX_VERSION_MINOR, OMX_VERSION_REVISION, and OMX_VERSION_STEP macros);
         # appending a directory path to gst-omx' internal OpenMAX IL headers fixes \
                this
-        d.appendVar("CFLAGS", " -I%s/omx/openmax" % srcdir)
+        d.appendVar("CFLAGS", " -I${S}/omx/openmax")
     elif omx_target == "rpi":
         # Dedicated Raspberry Pi OpenMAX IL support makes this package machine \
specific  d.setVar("PACKAGE_ARCH", d.getVar("MACHINE_ARCH", True))


[prev in list] [next in list] [prev in thread] [next in thread]