[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH 1/3] distrodata.bbclass/distro_check.py: Fix splits
From:       elizabeth.flanagan () intel ! com (Flanagan, Elizabeth)
Date:       2015-03-31 22:29:58
Message-ID: CAPhnLPAdrfkGABb8yXYOjsAtmmQAQDrA7SURC7mEm_4O118qkQ () mail ! gmail ! com
[Download RAW message or body]

On 31 March 2015 at 23:03, Burton, Ross <ross.burton at intel.com> wrote:
>
> On 31 March 2015 at 21:11, Beth Flanagan <elizabeth.flanagan at intel.com>
> wrote:
>>
>> +        if pnstripped.find("-native") != -1:
>
>
> Shouldn't this be .endswith() or .startswith() to prevent false-positives?
>

Not that we'd ever end up with something like foo-native-dummy (watch
someone prove that wrong), but we wouldn't want .endswith() here as
that would end up with bad data as well. I'm by no means happy with
the solution here, but for the time being it gets packagedata and
check_package working and not spitting out incorrect data.

I think we probably need to take a better look at packagedata and
check_package in 1.9, especially with how we map this to the actual
PN, but in this case, I was of the opinion that better was the enemy
of good enough.

> Ross
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.



-- 
Elizabeth Flanagan
Yocto Project
Build and Release

[prev in list] [next in list] [prev in thread] [next in thread]