[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH] populate_sdk_base: add auto-completion in setup
From:       richard.purdie () linuxfoundation ! org (Richard Purdie)
Date:       2014-06-29 8:01:52
Message-ID: 1404028912.28648.28.camel () ted
[Download RAW message or body]

On Tue, 2014-06-17 at 17:03 +0300, Laurentiu Palcu wrote:
> On Tue, Jun 17, 2014 at 03:16:53PM +0200, Dennis Meier wrote:
> > Signed-off-by: Dennis Meier <meier.dennis at siemens.com>
> > ---
> >  meta/classes/populate_sdk_base.bbclass |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> > index 35d837d..1182425 100644
> > --- a/meta/classes/populate_sdk_base.bbclass
> > +++ b/meta/classes/populate_sdk_base.bbclass
> > @@ -173,9 +173,8 @@ if [ $verbose = 1 ] ; then
> >  	set -x
> >  fi
> >  
> > -printf "Enter target directory for SDK (default: $DEFAULT_INSTALL_DIR): "
> >  if [ "$target_sdk_dir" = "" ]; then
> > -	read target_sdk_dir
> > +	read -e -p "Enter target directory for SDK (default: $DEFAULT_INSTALL_DIR): " target_sdk_dir
> >  	[ "$target_sdk_dir" = "" ] && target_sdk_dir=$DEFAULT_INSTALL_DIR
> >  else
> >  	echo "$target_sdk_dir"
> Moving the above printf in the 'if' branch will make this 'echo' look
> strange when the target directory is provided with the -d option... I
> believe you can remove this 'echo' completely though. There is another
> message, later, informing the user where the SDK gets installed.

I've applied a second patch to tweak this, thanks for the review.

Richard


[prev in list] [next in list] [prev in thread] [next in thread]