[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH 2/2] weston: fix make-lcms-configurable.patch
From:       ross.burton () intel ! com (Burton, Ross)
Date:       2014-05-29 22:49:46
Message-ID: CAJTo0LZ=jrroBnDG272i7TaZ3zkoZsoQJRHVi0QN7ixF77EE+Q () mail ! gmail ! com
[Download RAW message or body]

On 29 May 2014 15:30, Tim Orling <ticotimo at gmail.com> wrote:
> In AS_IF([test "x$enable_lcms" != "no"],
> "no" should have been "xno"

This patch doesn't quite satisfy the general goal we have of being
fully deterministic: if --enable-lcms is specified but the lcms
dependency isn't satisfied (i.e. it gained a version requirement and
we didn't have it) then configure would happily and silently disable
lcms.

A small tweak so that it's a fatal error if lcms is specified but the
deps are not present would be good.  Also have you approached upstream
about this patch?

Ross

[prev in list] [next in list] [prev in thread] [next in thread]