[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH] kernel-yocto.bbclass: Force do_diffconfig depends to ${PN}
From:       clarson () kergoth ! com (Chris Larson)
Date:       2014-02-28 21:33:56
Message-ID: CABcZANmW-+t+C5qiToMpB92U6ABina=bsJMSNJi6pDB0ZGAY7Q () mail ! gmail ! com
[Download RAW message or body]

On Fri, Feb 28, 2014 at 2:26 PM, Chris Larson <clarson at kergoth.com> wrote:

> I'm guessing that the idea was to add a dependency from diffconfig to
> kernel_configme whether or not diffconfig even exists, in order to be
> able to support a use case where kernel-yocto is inherited but cml1 is not,
> but I'd question the validity of such a use case, personally. I think
> either we should consider one of these options:
> 
> 1) Programmatically add the dependency with bb.build.addtask based on
> the availability of do_diffconfig
> 

https://gist.github.com/kergoth/9280305 shows what this one looks like,
which is the most versatile, but does add additional processing at the end
of parse time, though not much. I think this is probably our best bet as it
still supports the use cases implied by the way kernel-yocto.bbclass and
linux-yocto.inc are structured.


> 2) Use addtask to express the dependency in linux-yocto.inc, where
> do_kernel_configme gets added as a task. Having do_diffconfig depend on
> do_kernel_configme for a recipe that doesn't include linux-yocto.inc would
> result in breakage anyway unless they explicitly addtask do_kernel_configme
> in that recipe.
> 

https://gist.github.com/kergoth/9280352 shows this version, which would
mean that anyone using kernel-yocto.bbclass and cml1.bbclass but not
linux-yocto.bbclass wouldn't get the diffconfig -> kernel_configme
dependency set
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20140228/ad2166e2/attachment.html>



[prev in list] [next in list] [prev in thread] [next in thread]