[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [WIP][PATCH 17/20] librsvg: Fix dependencies for PACKAGECONFIG gdkpixbuf
From:       richard.purdie () linuxfoundation ! org (Richard Purdie)
Date:       2013-08-30 14:59:43
Message-ID: 1377874783.1059.98.camel () ted
[Download RAW message or body]

On Thu, 2013-08-29 at 10:49 -0700, Saul Wold wrote:
> On 08/29/2013 09:03 AM, Martin Jansa wrote:
> > * without gtk+ or gdk-pixbuf available it gets disabled even with \
> > --enable-pixbuf-loader 
> > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > ---
> > meta/recipes-gnome/librsvg/librsvg_2.32.1.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb \
> > b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb index 4818422..30846bf 100644
> > --- a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > +++ b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > @@ -29,7 +29,7 @@ PACKAGECONFIG ??= "croco gdkpixbuf"
> > # Support embedded CSS stylesheets (recommended upstream)
> > PACKAGECONFIG[croco] = "--with-croco,--without-croco,libcroco"
> > # gdk-pixbuf loader
> > -PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader"
> > +PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader,gtk+ \
> > gdk-pixbuf"
> 
> I think this needs to be a target only PACKAGECONFIG, as it will try to 
> depend on gtk+-native when building the librsvg-native.

Also do we really need gtk for the pixbuf loader? gtk2 theme engine
pulls in gtk+ elsewhere?

Cheers,

Richard


[prev in list] [next in list] [prev in thread] [next in thread]