[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH 2/2] shadow: remove grpconv argc check
From:       martin.donnelly () ge ! com (Martin Donnelly)
Date:       2013-02-28 15:18:00
Message-ID: 512F7528.3050605 () ge ! com
[Download RAW message or body]

On 28/02/2013 04:44, Saul Wold wrote:
> On 02/27/2013 04:58 AM, Martin Donnelly wrote:
>> The patched version of grpconv takes arguments but the check on
>> argc was not removed. This patch removes this check which
>> otherwise results in a spurious warning during rootfs creation.
>>
>> Signed-off-by: Martin Donnelly <martin.donnelly at ge.com>
>> ---
>>   .../shadow/files/add_root_cmd_options.patch        |   12 +++++++++++-
>>   1 files changed, 11 insertions(+), 1 deletions(-)
>>
>> diff --git
>> a/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>> b/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>> index 5edd3b8..ab87e35 100644
>> --- a/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>> +++ b/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>
> This patch needs a header also with Upstream-Status: Signed-off-by: and
> a brief explaination (if needed).
>

The existing patch already has the header and Upstream-Status in it, my 
patch to it simply makes the behaviour of the modified pwconv and 
grpconv in shadow-native consistent. I'll resend this patch with the 
Signed-off-by added to the header if you still want that?

Thanks

Martin



[prev in list] [next in list] [prev in thread] [next in thread]