[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] any objection to my cleaning up some packagegroup files in oe-core?
From:       rpjday () crashcourse ! ca (Robert P !  J !  Day)
Date:       2012-12-31 12:44:48
Message-ID: alpine.DEB.2.02.1212310737070.22859 () oneiric
[Download RAW message or body]

On Mon, 31 Dec 2012, Gary Thomas wrote:

> On 2012-12-30 12:44, Robert P. J. Day wrote:
> >
> >    specifically, in cases like this in packagegroup-core-sdk.bb:
> >
> > RDEPENDS_packagegroup-core-sdk
> >
> > could more cleanly be expressed as:
> >
> > RDEPENDS_${PN}
> >
> > could it not?  there are quite a few of those unnecessarily verbose
> > constructs, anyone mind if i submit a patch to make that change?
>
> Why stop there?  It seems that recipe could use more changes:
>   RPROVIDES_packagegroup-core-sdk = "task-core-sdk"
>   RREPLACES_packagegroup-core-sdk = "task-core-sdk"
>   RCONFLICTS_packagegroup-core-sdk = "task-core-sdk"
>
>   RDEPENDS_packagegroup-core-sdk = "\
>
> All of these should use _${PN}
>
> Also, most of the recipes in meta/recipes-core/packagegroups/* could
> use similar changes to make them more readable and maintainable.

  i just wanted to make sure there was nothing subtle happening that
would prevent something like that, although i'd do it a chunk (one
recipes-* directory?) at a time since some packagegroups don't lend
themselves to that sort of cleanup.

  consider recipes-extended/packagegroups/packagegroup-core-basic.bb.
it starts off so well, with the convenient "packagegroup-core-basic"
prefix for additional packages:

PACKAGES = "\
    packagegroup-core-basic \
    packagegroup-core-basic-libs \
    packagegroup-core-basic-utils \
    packagegroup-core-basic-extended \

then suddenly:

    packagegroup-core-dev-utils \
    packagegroup-core-multiuser \
    packagegroup-core-initscripts \
    packagegroup-core-sys-services \
    "

  grrrr ... you lose the ability to use the ${PN} abbreviation for the
second half of that list.  in cases like that, i'd just leave it alone
for now since abbreviating half the list would look like crap.

  i'll whip up a patch or two later today for the simpler stuff.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================




[prev in list] [next in list] [prev in thread] [next in thread]