[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openembedded-core
Subject:    [OE-core] [PATCH 34/52] logging: add bb* logging mechanisms for bash recipe functions
From:       sgw () linux ! intel ! com (Saul Wold)
Date:       2011-04-29 4:34:44
Message-ID: 4DBA3FE4.8040501 () linux ! intel ! com
[Download RAW message or body]

On 04/28/2011 09:30 PM, Darren Hart wrote:
>
>
> On 04/28/2011 02:05 AM, Richard Purdie wrote:
>> Hi Darren,
>>
>> On Wed, 2011-04-27 at 00:29 -0700, Saul Wold wrote:
>>> The following logging mechanisms are to be used in bash functions of recipes.
>>> They are intended to map one to one in intention and output format with the
>>> python recipe logging functions of a similar naming convention: bb.plain(),
>>> bb.note(), etc.
>>>
>>> For the time being, all of these print only to the task logs. Future
>>> enhancements may integrate these calls with the bitbake logging infrastructure,
>>> allowing for printing to the console as appropriate. The interface and intention
>>> statements reflect that future goal. Once it is in place, no changes will be
>>> necessary to recipes using these logging mechanisms.
>>
>> This looks good but could you do a search and replace of any existing
>> users of the oe* functions and then remove them from base.bbclass
>> please? At the very least they should be calling the bb* equivalents.
>> I'd like to clean up this kind of thing as we go.
>
> Sure thing. Is a follow-up patch acceptable or do you want me to
> resubmit these in one series?
>
Since we have pulled this set, a follow-up patch would be most excellent!

Thanks
	Sau!
> --
> Darren
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



[prev in list] [next in list] [prev in thread] [next in thread]