[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openejb-development
Subject:    Re: svn commit: r555774 - in /openejb/trunk/openejb3/itests/openejb-itests-client: ./ src/main/java/
From:       Dain Sundstrom <dain () iq80 ! com>
Date:       2007-07-16 20:08:54
Message-ID: 97175BFE-7699-4082-B766-6B361E25A28A () iq80 ! com
[Download RAW message or body]

On Jul 16, 2007, at 12:53 PM, Jacek Laskowski wrote:

> On 7/16/07, Dain Sundstrom <dain@iq80.com> wrote:
>> Also, please use Context.INITIAL_CONTEXT_FACTORY, instead of
>> inlineing the value.  It is much harder to make a typo when you use a
>> constant.
>
> I don't understand. Didn't I use the Context.INITIAL_CONTEXT_FACTORY?
> The line with the inlined value was replaced with the constant.

Sorry, I read the patch backwards.  You made the correct change from  
a hard coded string to the constant.

-dain
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic