[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openejb-cvs
Subject:    [jira] [Work logged] (TOMEE-4053) Dependency properties cleanup
From:       "ASF GitHub Bot (Jira)" <jira () apache ! org>
Date:       2022-10-31 11:27:00
Message-ID: JIRA.13483691.1664376199000.50507.1667215620064 () Atlassian ! JIRA
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/TOMEE-4053?focusedWorklogId=821905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821905 \
]

ASF GitHub Bot logged work on TOMEE-4053:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Oct/22 11:26
            Start Date: 31/Oct/22 11:26
    Worklog Time Spent: 10m 
      Work Description: rzo1 commented on code in PR #955:
URL: https://github.com/apache/tomee/pull/955#discussion_r1009305877


##########
tomee/tomee-microprofile/mp-common/pom.xml:
##########
@@ -27,7 +27,61 @@
   <artifactId>mp-common</artifactId>
   <name>TomEE :: TomEE :: MicroProfile Common</name>
 
+  <dependencyManagement>

Review Comment:
   same comment as above



##########
tck/microprofile-tck/pom.xml:
##########
@@ -63,4 +63,134 @@
       </modules>
     </profile>
   </profiles>
+
+  <dependencyManagement>

Review Comment:
   Any reason for adding them under `dependencyManagement` in the `microprofile-tck`  \
again? The only difference is the `scope = test`, which is decleared on each artifact \
in the related sub-modules? 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 821905)
    Time Spent: 4.5h  (was: 4h 20m)

> Dependency properties cleanup
> -----------------------------
> 
> Key: TOMEE-4053
> URL: https://issues.apache.org/jira/browse/TOMEE-4053
> Project: TomEE
> Issue Type: Improvement
> Reporter: Gwénaël Ruelland
> Priority: Minor
> Time Spent: 4.5h
> Remaining Estimate: 0h
> 
> Proposed PR for properties consistency  
> * properties are of the form 'version.groupid' or 'groupid.version' : changed most \
>                 to the 'version.groupid' form for coherence.
> * regrouping properties by feature blocks
> * ordering by name were usefull



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[prev in list] [next in list] [prev in thread] [next in thread]