[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    Re: libagent: fix agentx_context_object_nfind
From:       Alexander Bluhm <alexander.bluhm () gmx ! net>
Date:       2021-05-31 15:09:04
Message-ID: YLT8ELn3tdU0zrfh () t430s ! bluhm ! invalid
[Download RAW message or body]

On Sat, May 01, 2021 at 06:59:59PM +0200, Martijn van Duren wrote:
> The parameters for ax_oid_cmp are swapped.
> This fixes the few failing regress tests I just committed.
> 
> OK?

OK bluhm@

> Index: agentx.c
> ===================================================================
> RCS file: /cvs/src/lib/libagentx/agentx.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 agentx.c
> --- agentx.c	1 May 2021 16:44:17 -0000	1.9
> +++ agentx.c	1 May 2021 16:59:08 -0000
> @@ -675,7 +675,7 @@ agentx_context_object_nfind(struct agent
>  
>  	axo = RB_NFIND(axc_objects, &(axc->axc_objects), &axo_search);
>  	if (!inclusive && axo != NULL &&
> -	    ax_oid_cmp(&(axo_search.axo_oid), &(axo->axo_oid)) <= 0) {
> +	    ax_oid_cmp(&(axo->axo_oid), &(axo_search.axo_oid)) <= 0) {
>  		axo = RB_NEXT(axc_objects, &(axc->axc_objects), axo);
>  	}
>  
> 

[prev in list] [next in list] [prev in thread] [next in thread]