[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    Re: Diff
From:       Stefan Sperling <stsp () stsp ! name>
Date:       2021-05-31 11:43:49
Message-ID: YLTL9UilTKHfF0n/ () camille ! stsp ! name
[Download RAW message or body]

On Mon, May 31, 2021 at 02:33:03PM +0300, Reuven Plevinsky wrote:
> Hi,
> Here is my diff:
> https://github.com/reuvenP/src/commit/db909be68a3b03e68787de55d218388f33c4c4c6

Not everyone wants to read diffs in a browser.

Sending your diff inline will work better, like this:

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index cd0c12dcd3ba..74ce2621f762 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -3832,8 +3832,8 @@ syn_cache_add(struct sockaddr *src, struct sockaddr *dst, struct tcphdr *th,
 		 * leading to serious problems when traversing these
 		 * broken firewalls.
 		 *
-		 * With the default sbmax of 256K, a scale factor
-		 * of 3 will be chosen by this algorithm.  Those who
+		 * With the default sbmax of 2MB, a scale factor
+		 * of 6 will be chosen by this algorithm.  Those who
 		 * choose a larger sbmax should watch out
 		 * for the compatibility problems mentioned above.
 		 *

[prev in list] [next in list] [prev in thread] [next in thread]