[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    Re: unbound 1.7.0
From:       Florian Obser <florian () openbsd ! org>
Date:       2018-03-28 16:49:55
Message-ID: 20180328164955.fasrnwoplnghkpn7 () imap ! narrans ! de
[Download RAW message or body]

On Wed, Mar 28, 2018 at 12:31:01PM +0200, Florian Obser wrote:
> I guess nobody is going to review a 10k line diff...

so benno actually read the diff and points out that we need this:

(already reported upstream)

diff --git services/authzone.c services/authzone.c
index 13e36b2c..fac8e4ed 100644
--- services/authzone.c
+++ services/authzone.c
@@ -5946,7 +5946,7 @@ static char*
 dup_all(char* str)
 {
 	char* result = strdup(str);
-	if(!str) {
+	if(!result) {
 		log_err("malloc failure");
 		return NULL;
 	}


-- 
I'm not entirely sure you are real.

[prev in list] [next in list] [prev in thread] [next in thread]