[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    [patch] Change size's type from int to size_t in ldd.c
From:       Nan Xiao <xiaonan830818 () gmail ! com>
Date:       2017-09-28 3:31:58
Message-ID: d4ba314c-c1f2-0708-4536-54341ac44f41 () gmail ! com
[Download RAW message or body]

Hi tech@,

I think the type of size variable should be more accurate to use size_t
instead of int.

Best Regards
Nan Xiao

Index: ldd.c
===================================================================
RCS file: /cvs/src/libexec/ld.so/ldd/ldd.c,v
retrieving revision 1.21
diff -u -p -r1.21 ldd.c
--- ldd.c	2 Jul 2017 19:06:12 -0000	1.21
+++ ldd.c	28 Sep 2017 03:16:10 -0000
@@ -96,7 +96,8 @@ doit(char *name)
 {
 	Elf_Ehdr ehdr;
 	Elf_Phdr *phdr;
-	int fd, i, size, status, interp=0;
+	int fd, i, status, interp=0;
+	size_t size;
 	char buf[PATH_MAX];
 	struct stat st;
 	void * dlhandle;

[prev in list] [next in list] [prev in thread] [next in thread]