[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    Re: acpithinkpad: new hid
From:       Mark Kettenis <mark.kettenis () xs4all ! nl>
Date:       2017-02-25 19:25:11
Message-ID: 201702251925.v1PJPBDG003063 () glazunov ! sibelius ! xs4all ! nl
[Download RAW message or body]

> Date: Sat, 25 Feb 2017 13:09:38 -0600
> From: joshua stein <jcs@openbsd.org>
> 
> New ThinkPads use a different ACPI HID.

Hmm, I don't really see the value of having #defines for these HIDs.
Could you just add the strings and remove the existing ACPI_DEV_IBM
and ACPI_DEV_LENOVO #defines?

> Index: sys/dev/acpi/acpireg.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/acpi/acpireg.h,v
> retrieving revision 1.36
> diff -u -p -u -p -r1.36 acpireg.h
> --- sys/dev/acpi/acpireg.h	10 Jul 2016 20:36:41 -0000	1.36
> +++ sys/dev/acpi/acpireg.h	25 Feb 2017 19:07:28 -0000
> @@ -766,6 +766,7 @@ struct acpi_ivrs {
>  #define ACPI_DEV_ASUS1	"ATK0100"	/* ASUS Special Device */
>  #define ACPI_DEV_IBM	"IBM0068"	/* IBM ThinkPad support */
>  #define ACPI_DEV_LENOVO	"LEN0068"	/* Lenovo ThinkPad support */
> +#define ACPI_DEV_LENOVO2 "LEN0268"	/* Lenovo ThinkPad support */
>  #define ACPI_DEV_ASUSAIBOOSTER	"ATK0110"	/* ASUSTeK AI Booster */
>  #define ACPI_DEV_TOSHIBA_LIBRETTO	"TOS6200"	/* Toshiba Libretto support */
>  #define ACPI_DEV_TOSHIBA_DYNABOOK	"TOS6207"	/* Toshiba Dynabook support */
> Index: sys/dev/acpi/acpithinkpad.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/acpi/acpithinkpad.c,v
> retrieving revision 1.54
> diff -u -p -u -p -r1.54 acpithinkpad.c
> --- sys/dev/acpi/acpithinkpad.c	7 Feb 2017 05:18:07 -0000	1.54
> +++ sys/dev/acpi/acpithinkpad.c	25 Feb 2017 19:07:28 -0000
> @@ -181,7 +181,10 @@ struct cfdriver acpithinkpad_cd = {
>  };
>  
>  const char *acpithinkpad_hids[] = {
> -	ACPI_DEV_IBM, ACPI_DEV_LENOVO, 0
> +	ACPI_DEV_IBM,
> +	ACPI_DEV_LENOVO,
> +	ACPI_DEV_LENOVO2,
> +	0
>  };
>  
>  int
> 
> 

[prev in list] [next in list] [prev in thread] [next in thread]