[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openbsd-tech
Subject:    LLVM warning in sys/compat/linux/linux_misc.c
From:       Brad Smith <brad () comstyle ! com>
Date:       2013-11-29 3:05:47
Message-ID: 20131129030547.GB25021 () rox ! home ! comstyle ! com
[Download RAW message or body]

Remove unsigned comparison < 0.

../../../../compat/linux/linux_misc.c:1531:24: error: comparison of unsigned \
expression < 0 is always false [-Werror,-Wtautological-compare]

Comments? OK?


Index: linux_misc.c
===================================================================
RCS file: /home/cvs/src/sys/compat/linux/linux_misc.c,v
retrieving revision 1.83
diff -u -p -r1.83 linux_misc.c
--- linux_misc.c	25 Oct 2013 05:10:03 -0000	1.83
+++ linux_misc.c	29 Nov 2013 02:32:48 -0000
@@ -1657,7 +1657,7 @@ linux_sys_prctl(struct proc *p, void *v,
 
 	switch (SCARG(uap, option)) {
 	case LINUX_PR_SET_PDEATHSIG:
-		if (SCARG(uap, arg2) < 0 || SCARG(uap, arg2) >= LINUX__NSIG)
+		if (SCARG(uap, arg2) >= LINUX__NSIG)
 			return (EINVAL);
 		ed->pdeath_signal = SCARG(uap, arg2);
 		break;

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.


[prev in list] [next in list] [prev in thread] [next in thread]